Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: events selected by user during table poll are ignored #77

Open
podliashanyk opened this issue Mar 11, 2024 · 2 comments
Open

[BUG]: events selected by user during table poll are ignored #77

podliashanyk opened this issue Mar 11, 2024 · 2 comments
Labels
beta Part of beta release bug Something isn't working

Comments

@podliashanyk
Copy link
Contributor

If user selects/deselects event(s) via checkbox while table poll is ongoing, the checkbox erroneously changes state but the selection changes are not persisted. After table poll is completed the UI changes to the affected checkbox(es) disappear as well indicating to the user that changes attempted during table poll were not persisted.

If it is not possible to perform concurrent operations during table poll, all other operations should be disabled during table poll (page overlay with loading indicator for example).
Alternatively a different and a more efficient event update mechanism than poll of the entire table (#4) could potentially automatically solve this bug.

@podliashanyk podliashanyk added bug Something isn't working beta Part of beta release labels Mar 11, 2024
@podliashanyk
Copy link
Contributor Author

Might be fixed by #87

@podliashanyk
Copy link
Contributor Author

podliashanyk commented May 28, 2024

Might be fixed by #87

Not completely.
What is fixed:

  • Table refresh with ntie #87 introduces a much more efficient rows update mechanism and thereby dramatically reduces the 'surface area' for this bug to occur.
  • Also HTMX requests synchronization in Table refresh with ntie #87 fixes the row-selection-state aspect of this bug. Meaning that if user via checkbox selects several rows while some other request is ongoing, all those changes will eventually be persisted in the app session and therefore in the view.

Not yet fixed:

  • Misleading UI of the checkbox in the indeterminate state, ie state where user has ticked the checkbox but the request was not yet processed. The row seems erroneously selected due to CSS browser defaults for the checkbox input tag, see the Indeterminate checkbox in the example below:
    Screenshot 2024-05-28 at 14 31 42
    The browser defaults for [type="checkbox"]:checked need to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Part of beta release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant