Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to toggle_profile_activation command to turn all off #756

Open
johannaengland opened this issue Apr 15, 2024 · 4 comments
Open

Comments

@johannaengland
Copy link
Contributor

johannaengland commented Apr 15, 2024

Originally posted by @hmpf in #749 (review)

@hmpf
Copy link
Contributor

hmpf commented Apr 16, 2024

I think you can combine this one and #757 and toggle_notification_profiles into a single command.

"list" is incompatible with the others, it might even be the fallback if there are no flags.

@johannaengland
Copy link
Contributor Author

I have trouble picturing how that would look like?
Would list be a flag that if used like this toggle_profile_activation --list just list all notification profiles?

That seems un-intuitive for me, because what if we want to later add another management command that does something else with notification profiles and there it might also be useful to know all profiles, then we would have to double the code or call this command before even though we don't want to do anything with the activation.

I would prefer to have these separate and then we can mention the management command in the helptext for toggle_profile_activation.

@lunkwill42
Copy link
Member

Add flag where? To what? What are we talking about here?

@johannaengland johannaengland changed the title Add flag to toggle profile activation Add flag to toggle_profile_activation command to turn all off Apr 17, 2024
@johannaengland
Copy link
Contributor Author

This can then also be added to the documentation introduced in #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants