Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irrationality of the square root of 2 #1211

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

EgbertRijke
Copy link
Collaborator

@EgbertRijke EgbertRijke commented Oct 25, 2024

The goal of this PR is twofold:

  • To prove the irrationality of the square root of 2, and
  • Cleaning up some of the elementary number theory files related to divisibility to make them more easily usable and understandable.

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented Oct 27, 2024

Cool! I'll wait to submit the 100-theorems list to Freek until after this PR is merged :) #1203

is-decidable-is-odd-ℤ a = is-decidable-neg (is-decidable-is-even-ℤ a)
```

### `0` is an even integer
Copy link
Collaborator

@fredrik-bakke fredrik-bakke Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're switching between using code guarded algebraic expressions in your headers and latex rendered ones in this PR. While code guarding is certainly the more established style in the library (there is only one place in the whole library where latex rendered text is used in a header:
https://unimath.github.io/agda-unimath/ring-theory.localizations-rings.html#the-type-of-localizations-of-a-ring-r-at-an-element-x-is-contractible), the LaTeX rendering looks a lot better in my opinion, so I'm tempted to suggest you use only latex rendered algebraic expressions in headers in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants