Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inorganic is duplicated under talents for bioroids #22

Open
Ziiro opened this issue Feb 8, 2019 · 1 comment
Open

Inorganic is duplicated under talents for bioroids #22

Ziiro opened this issue Feb 8, 2019 · 1 comment
Labels

Comments

@Ziiro
Copy link

Ziiro commented Feb 8, 2019

Describe the bug
If you create a character with the "Bioroid" Archetype, the talent "Inorganic" appears multiple times.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new character
  2. Leave the setting on "All"
  3. Select "Bioroid" Archetype
  4. Realize already that something is wrong.
    image
  5. Scroll down and confirm that something is definitely wrong:
    image

Expected behavior
Inorganic should only appear once.

Desktop (please complete the following information):
Windows 10, Chrome

Additional context
I've looked at the code myself here on github, and I'm wondering if the fact that the data is duplicated is the problem:

https://github.com/SkyJedi/RPG-Web-Character-Creator/blob/7f91378dda749125b30664616d9e2338a9e2f0b0/src/data/archetypes/CRB.json#L223-L237
https://github.com/SkyJedi/RPG-Web-Character-Creator/blob/fc84a52466e52d46f8443719b7884c5ae702e397/src/data/archetypes/SOTB.json#L26-L39

@ShaneK
Copy link
Member

ShaneK commented May 16, 2020

This relates to a much larger issue I've seen when developing the importer for RPG Sessions where data is just sorta joined together after it's all been added. Even though it's separated by source book, that separation is pretty much ignored when allowing you to select gear and what not, and in the case of equipment only the "latest" copy of the item is taken.

@ShaneK ShaneK added the bug label May 16, 2020
KoljaTM pushed a commit to KoljaTM/RPG-Web-Character-Creator that referenced this issue Jun 6, 2021
- made a distinction between CRB and SotB bioroids
ShaneK pushed a commit that referenced this issue Jun 6, 2021
- made a distinction between CRB and SotB bioroids

Co-authored-by: Kolja Markwardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants