-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree support tip generation leaves corners unsupported #2037
Comments
Hey @richfelker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been experimenting with the improved tree supports with a very simple test case, a 28 mm cube floating 20 mm above the build plate, and have found that, regardless of top rate and tip diameter, the corners of the square are left inconsistently supported or entirelyy unsupported. This seems to be a consequence of
generateSupportInfillLines
ingenerateTips
generating an infill pattern that does not reach the full extents of the region, especially not into corners. Modifying it to callgenerateSupportInfillLines
withinclude_walls
true helps but does not fully solve the problem, because iterating along the path to get locations for tips does not necessarily hit the vertices; it can step past one. It also makes the tip structure kinda weird.I think the real fix is probably doing some kind of second pass that iterates over the outline and ensures there is a tip at each sharp corner.
The text was updated successfully, but these errors were encountered: