Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to eliminate the need of patching golang.org/x/crypto/ssh #17

Open
stevapple opened this issue Aug 28, 2024 · 2 comments
Open

Try to eliminate the need of patching golang.org/x/crypto/ssh #17

stevapple opened this issue Aug 28, 2024 · 2 comments

Comments

@stevapple
Copy link
Contributor

It would be great if we don't vendor a modified copy of the library. It's a perfect time now to check which API we need doesn't exist now, and try to get them into the new golang.org/x/crypto/ssh/v2 package.

@stevapple
Copy link
Contributor Author

stevapple commented Aug 28, 2024

@iBug 42b2075 is the only patch to existing x/crypto/ssh codebase, can you elaborate on the context? I didn't find a related issue in https://github.com/golang/go

@iBug
Copy link
Member

iBug commented Aug 28, 2024

The context is loosely in the commit message. For Ubuntu 22.04 and lower, the packaged openssh-server doesn't implement the new "ping" protocol, and would exit immediately upon receiving one (unknown packet type 192). We found it easier to disable this optional feature altogether in that patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants