Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect-ai-vscode adds unnecessary entries to .gitignore. #1194

Open
tobiasraabe opened this issue Jan 27, 2025 · 1 comment
Open

inspect-ai-vscode adds unnecessary entries to .gitignore. #1194

tobiasraabe opened this issue Jan 27, 2025 · 1 comment

Comments

@tobiasraabe
Copy link
Contributor

tobiasraabe commented Jan 27, 2025

Hi!

When I have the extension running in a project with a .gitignore file and create a Python file, I believe the inspect-ai-vscode extension adds entries to the .gitignore file, like logs/. I think it comes from here.

ensureGitignore(path, ignorePaths());

I appreciate the helpfulness of the extension, but I would prefer it if it didn't automatically add entries to my .gitignore file. It can be disruptive, especially when I don't need these entries.

An opt-out setting, better detection of an inspect-ai workspace or removing the feature would be candidates for solving my issue.

@jjallaire
Copy link
Collaborator

@dragonstyle I'd be okay with our removing this entirely given that the standard GitHub .gitignore file already ignores __pycache__/ and .env: https://github.com/github/gitignore/blob/main/Python.gitignore. I think there could be a case (but not that strong) for logs/ but only if this code triggered in an actual Inspect project. The fact that it triggers in any project with a .py file to makes it pretty problematic.

So my vote is remove this behavior.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants