Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL as favicon #2851

Closed
MeridianGH opened this issue Feb 11, 2025 · 2 comments
Closed

Allow URL as favicon #2851

MeridianGH opened this issue Feb 11, 2025 · 2 comments
Labels
good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged

Comments

@MeridianGH
Copy link

Search Terms

favicon, url, options

Problem

I'd like to use a static, external URL (such as https://raw.githubusercontent.com/.../favicon.png) from a different repository as the favicon. I'm pretty sure this even used to work, maybe before .png support was added in #2791.

Suggested Solution

Maybe test the favicon option with regex or String.startsWith for https?:// and if this check is true, simply use its value as the favicon href.

@Gerrit0 Gerrit0 added help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Feb 12, 2025
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 12, 2025

This might have worked in a plugin which implemented this before it was added to TypeDoc, but never worked here, PR welcome! This is a pretty easy change to make.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 14, 2025

... less easy than I thought actually, not quite as trivial as just adjusting the validation function, which is what I thought originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Projects
None yet
Development

No branches or pull requests

2 participants