Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] pushing directly to main branch #5

Closed
cspotcode opened this issue Jul 14, 2021 · 7 comments
Closed

[meta] pushing directly to main branch #5

cspotcode opened this issue Jul 14, 2021 · 7 comments

Comments

@cspotcode
Copy link
Collaborator

I've been pushing directly to the main branch. If that gets annoying, let me know and I'll start doing my work in topic branches and creating pull requests.

@keithlayne
Copy link
Collaborator

I was gonna use branches. I'm not annoyed unless you don't rebase :)

It might be a little funky with actions, I'll probably filter to my branch when fooling around, maybe even use a fake gh-pages branch until it's worked out.

@keithlayne
Copy link
Collaborator

I was also thinking of using a fork, but that might be needlessly compilcated when testing actions.

@cspotcode
Copy link
Collaborator Author

Ok, I just pushed something to main a few seconds ago, but I'll switch to using branches from here on.

@cspotcode
Copy link
Collaborator Author

For lack of a better place to mention what I pushed, I'll explain it here:

I updated the yarn work script to create a basic index.html and to push everything it renders to gh-pages. Feel free to totally change, replace, modify how I'm doing that. It's definitely sub-optimal.

https://typestrong.org/typedoc-auto-docs/

I wanted to start pushing to make it easier to share results: what's working, what's not, etc.

@cspotcode
Copy link
Collaborator Author

I also threw together a db.ts which can be used to store a SQLite database in git. I have no idea if using sqlite is a good idea. I'm sure you have some good ideas about how you want to store state.

@keithlayne
Copy link
Collaborator

SQLite is wonderful. I don't know if we need it's power, but I think it's reasonable. Most of the things that make me like it aren't really applicable here I don't think, but I'm fine with that. Plus it may be obvious later that we need something like that.

Pretty sure though it can handle transactions from multiple processes and handle all kinds of things that are hard with files in general. We may not need all that, but I can imagine it very easily.

@cspotcode
Copy link
Collaborator Author

I spoke too soon; I accidentally did not push that code to the main branch.

I have pushed it to a pull request: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants