-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript types are likely incorrect #270
Comments
@brianloveswords , you may be interested. I see that you fixed the typings some months ago. |
I think this types definition is the correct one: // Note that @types/browserify is not used for a reason:
// https://github.com/TypeStrong/tsify/issues/267
import * as typescript from "typescript";
declare namespace tsify {
export interface Options {
exclude?: string[];
files?: string[];
global?: boolean;
include?: string[];
m?: string;
p?: string | Record<string, any>;
project?: string | Record<string, any>;
t?: string;
typescript?: string | typeof typescript;
}
}
declare var tsify: (b: any, opts: tsify.Options) => any;
export = tsify; |
Also, |
Yeah, you are right. If you want to open a PR for the change, that would be appreciated.
IMO it's unrealistic to support every project and compiler option via command line and plugin options. Use a |
Compiling, then running the following TypeScript module output
undefined
:Of course, passing
tsify
to Browserify would throw aCannot find module 'undefined'
error.The text was updated successfully, but these errors were encountered: