Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using regex to parse code is bad practice, should be done with JS parser and AST #44

Closed
roypeled opened this issue Jul 4, 2024 · 2 comments

Comments

@roypeled
Copy link
Collaborator

roypeled commented Jul 4, 2024

The regex parsing engine was not handling compiled code correctly, it would extract malformed tokens when self invoked functions and compiled imported modules were introduced in the code ((0, imported)(arg)).

I created a PR to fix the issue here:
#43

@LironHazan
Copy link
Collaborator

Welcome Roy! I'm honored getting PRs from you!

@LironHazan
Copy link
Collaborator

I think your PR is also relevant to this thread btw
#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants