Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Tests #40

Open
ParadaCarleton opened this issue Sep 19, 2021 · 2 comments
Open

Performance Tests #40

ParadaCarleton opened this issue Sep 19, 2021 · 2 comments

Comments

@ParadaCarleton
Copy link
Member

Would be nice to make sure PRs don't degrade performance as part of our tests; no idea how this would be done but there's probably some way to go about it.

@sethaxen
Copy link
Member

I agree, a benchmarking GitHub Action, either run automatically or triggered via a label, would be good.

Since you and I have been noting opposite trends comparing the performance of ParetoSmooth.jl and PSIS.jl, I think it makes sense to agree on what even is a good benchmark for psis. How about this?

using ParetoSmooth, Random, BenchmarkTools
Random.seed!(42)
log_ratios = randn(100, 1_000, 4)
r_eff = ones(size(log_ratios, 1))
@benchmark psis($log_ratios; r_eff=$r_eff)

@ParadaCarleton
Copy link
Member Author

ParadaCarleton commented Sep 30, 2021

I agree, a benchmarking GitHub Action, either run automatically or triggered via a label, would be good.

Since you and I have been noting opposite trends comparing the performance of ParetoSmooth.jl and PSIS.jl, I think it makes sense to agree on what even is a good benchmark for psis. How about this?

using ParetoSmooth, Random, BenchmarkTools
Random.seed!(42)
log_ratios = randn(100, 1_000, 4)
r_eff = ones(size(log_ratios, 1))
@benchmark psis($log_ratios; r_eff=$r_eff)

Looks pretty good! Do you know how we'd set up a benchmarking GitHub Action?

Although, I would suggest a larger input for log_ratios, maybe 1000, since I'd like to know how it deals with large datasets (where performance matters the most).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants