Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the benchmarks posted? #82

Closed
Red-Portal opened this issue Aug 11, 2024 · 6 comments
Closed

Where are the benchmarks posted? #82

Red-Portal opened this issue Aug 11, 2024 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@Red-Portal
Copy link
Member

Hi, it seems like the benchmarks are no longer being posted on turinglang.org/AdvancedVI.jl/benchmark. Was it moved to a different url? @yebai @shravanngoswamii

@Red-Portal Red-Portal added the documentation Improvements or additions to documentation label Aug 11, 2024
@shravanngoswamii
Copy link
Member

We changed the benchmark workflow to run only on PRs! See here: #74

@Red-Portal
Copy link
Member Author

Then is there a way I can monitor change in performance across commits?

@shravanngoswamii
Copy link
Member

Then is there a way I can monitor change in performance across commits?

As of now, I don't think there is any way! We have to roll back to previous workflow if that's required!

@yebai
Copy link
Member

yebai commented Aug 12, 2024

Since every (substantial) change has to go through a PR, it should be sufficient to benchmark PRs only. Even with the previous setup, it only benchmarks the final commit in PRs instead of all commits.

@shravanngoswamii What is strange is benchmarks seem not to be running even for PRs; see: #84

@Red-Portal
Copy link
Member Author

Red-Portal commented Aug 12, 2024

I can imagine that performance bugs can appear and disappear due to changes upstream, not just local changes introduced through PRs. Benchmarking only on PRs won't be able to catch such performance bugs in a timely fashion would it?

@yebai
Copy link
Member

yebai commented Sep 10, 2024

Benchmarks are back live: https://turinglang.org/AdvancedVI.jl/benchmarks/

I don't think benchmarks are meant to track upstream performance regression. If you want to do that, you may want to set up a regular interval to run benchmarks, e.g. daily / weekly.

@yebai yebai closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants