-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where are the benchmarks posted? #82
Comments
We changed the benchmark workflow to run only on PRs! See here: #74 |
Then is there a way I can monitor change in performance across commits? |
As of now, I don't think there is any way! We have to roll back to previous workflow if that's required! |
Since every (substantial) change has to go through a PR, it should be sufficient to benchmark PRs only. Even with the previous setup, it only benchmarks the final commit in PRs instead of all commits. @shravanngoswamii What is strange is benchmarks seem not to be running even for PRs; see: #84 |
I can imagine that performance bugs can appear and disappear due to changes upstream, not just local changes introduced through PRs. Benchmarking only on PRs won't be able to catch such performance bugs in a timely fashion would it? |
Benchmarks are back live: https://turinglang.org/AdvancedVI.jl/benchmarks/ I don't think benchmarks are meant to track upstream performance regression. If you want to do that, you may want to set up a regular interval to run benchmarks, e.g. daily / weekly. |
Hi, it seems like the benchmarks are no longer being posted on
turinglang.org/AdvancedVI.jl/benchmark
. Was it moved to a different url? @yebai @shravanngoswamiiThe text was updated successfully, but these errors were encountered: