Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of proposals versus proposals of arrays #53

Open
devmotion opened this issue May 12, 2021 · 1 comment
Open

Array of proposals versus proposals of arrays #53

devmotion opened this issue May 12, 2021 · 1 comment

Comments

@devmotion
Copy link
Member

It is confusing that Proposals such as StaticProposal accept arrays of proposals and one can also specify arrays of Proposals in the MetropolisHastings sampler. Would it be sufficient to only support arrays of proposals (and similar for tuples etc.)?

@cpfiffer
Copy link
Member

Yeah, that's a weird quirk of AdvancedMH's overly-permissive proposal system. If I had to pick one of these syntaxes I would prefer to do as you suggest and make Proposal require either a function or a distribution rather than allow arrays. My reasoning for this is that I absolutely love this syntax:

props = (a=StaticProposal(Normal(0,1)), b=StaticProposal(InverseGamma(2,3)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants