Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add varname tests from DPPL + format repo #111

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Dec 5, 2024

cf. TuringLang/DynamicPPL.jl#737

DynamicPPL had some tests for basic varname functionality, which should be tested here instead. I've moved the tests.

The remainder of the changes are formatting.

@penelopeysm penelopeysm requested a review from mhauru December 5, 2024 14:53
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should set up a formatter GHA for AbstractPPL at some point.

@penelopeysm
Copy link
Member Author

@mhauru There is one since about 15 minutes ago :) #110

Actually, if you don't mind, I'll format the entire repo before merging this one.

@penelopeysm penelopeysm changed the title Add varname tests from DPPL Add varname tests from DPPL + format repo Dec 5, 2024
@penelopeysm penelopeysm merged commit 903e0c6 into main Dec 5, 2024
12 checks passed
@penelopeysm penelopeysm deleted the py/add-dppl-varname-tests branch December 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants