-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[turf-ellipse] fixes the wrong shape when drawing "big ellipses" near the poles #2739
Open
hadbn
wants to merge
8
commits into
Turfjs:master
Choose a base branch
from
hadbn:fix-ellipse-harversine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 25, 2024
-
-Fixes the wrong behavior of turf-ellipse when drawing "big ellipses" near the poles -Fixes the wrong behavior of turf-ellipse when rotating an ellipse. The rotation is now fully taken account during the calculation of the geometry. -Adds two test to directly check both previous points -Fixes one of the existing test `turf-ellipse` which was not launched when launching `pnpm test` -Changes the test `turf-ellipse` so that it fits the fixes made in the calculation of the geometry
Configuration menu - View commit details
-
Copy full SHA for e46298d - Browse repository at this point
Copy the full SHA e46298dView commit details -
update [turf-standard-deviational-ellipse] for compatibility with the…
… fix of turf-ellipse
Configuration menu - View commit details
-
Copy full SHA for ade9913 - Browse repository at this point
Copy the full SHA ade9913View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e7a500 - Browse repository at this point
Copy the full SHA 9e7a500View commit details
Commits on Oct 30, 2024
-
feat [turf-ellipse] distributes points along the circumference so tha…
…t they are equidistant from one other
Configuration menu - View commit details
-
Copy full SHA for bc6c51a - Browse repository at this point
Copy the full SHA bc6c51aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 775d563 - Browse repository at this point
Copy the full SHA 775d563View commit details -
Configuration menu - View commit details
-
Copy full SHA for d72ba03 - Browse repository at this point
Copy the full SHA d72ba03View commit details -
Configuration menu - View commit details
-
Copy full SHA for cad1832 - Browse repository at this point
Copy the full SHA cad1832View commit details
Commits on Nov 4, 2024
-
updates [turf-ellipse] the distribution of points along the circumfer…
…ence is now optional. The default value for accuracy (0) leads to the same result as previously. Using custom values for accuracy will distribute points along the circumference (which is more precise for "thin" ellipses, but more expensive).
Configuration menu - View commit details
-
Copy full SHA for f4ed1c5 - Browse repository at this point
Copy the full SHA f4ed1c5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.