-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new point-to-polygon-distance package #2735
Added new point-to-polygon-distance package #2735
Conversation
Looking good thanks @pachacamac. Glad to see it works with polygon holes as well. Before it's ready to merge we might need to flesh it out in a couple of areas:
Sorry if that's more involved than you expected. Happy to co-author though if your time is limited. |
Thanks for pointing out the options. Missed that I can just forward this to the |
@smallsaucepan anything else needed from my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @pachacamac. Looks good.
One final task - could you please add this to the packages/turf/ package as well? That's the aggregator package that pulls in all the other turf-* packages for easy importing.
Pretty sure all you need to do is add point-to-polygon-distance as a package dependency, and re-export the main function from index.ts
@smallsaucepan done 👍 |
Thanks @pachacamac. Let's give it a spin through CI. |
…d. Re-adding new package as a dependency in my env and letting lock file regenerate to previous format.
Little bump in the road related to the pnpm-lock file. Pushed a quick fix and CI is green, so this is ready to merge 🎉 Thanks for your work on this @pachacamac. This was our most 👍-ed outstanding issue. |
Please fill in this template. Use a meaningful title for the pull request. Include the name of the package modified.
Submitting a new TurfJS Module.
./scripts/generate-readmes
to createREADME.md
.package.json
using "Full Name <@github Username>".Resolves #1743