Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Module renaming for v7 #2163

Closed
1 task
rowanwins opened this issue Jul 31, 2021 · 2 comments
Closed
1 task

Proposal: Module renaming for v7 #2163

rowanwins opened this issue Jul 31, 2021 · 2 comments
Milestone

Comments

@rowanwins
Copy link
Member

If we're working towards a release of v7 then now would be a good time to rename any modules as a breaking change.

  • lineIntersect to become intersectionPoints. Rationale being is that this module supports both polygons and lines, and I think the proposed name is a bit clearer as to what it does and returns.

Any other thoughts for candidates @mfedderly @JamesLMilner @twelch ?

@JamesLMilner
Copy link
Collaborator

I agree that lineIntersect is a bit confusing considering it works on LineStrings and Polygons. I would be happy to rename it to intersectionPoints if that helps provide clarity to users

@mfedderly
Copy link
Collaborator

I don't know of any other renames offhand, but I made a PR for lineIntersect #2187

@smallsaucepan smallsaucepan modified the milestones: v7, v8 Dec 9, 2023
@Turfjs Turfjs locked and limited conversation to collaborators Dec 7, 2024
@smallsaucepan smallsaucepan converted this issue into discussion #2764 Dec 7, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants