Merge pull request #2563 from superDoss/fix_booleanvalid_polygon

[@turf/boolean-valid] fix #checkClosingRing to check for polygon being closed
Turfjs · Aug 5, 2024 · cc680d3 · cc680d3
2 parents e3fb086 + 6fb4e23
commit cc680d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/turf-boolean-valid/index.ts b/packages/turf-boolean-valid/index.ts
@@ -90,7 +90,7 @@ function booleanValid(feature: Feature<any> | Geometry) {
 
 function checkRingsClose(geom: Position[]) {
   return (
-    geom[0][0] === geom[geom.length - 1][0] ||
+    geom[0][0] === geom[geom.length - 1][0] &&
     geom[0][1] === geom[geom.length - 1][1]
   );
 }

diff --git a/packages/turf-boolean-valid/test/false/Polygon/not-closing-ring.geojson b/packages/turf-boolean-valid/test/false/Polygon/not-closing-ring.geojson
@@ -0,0 +1,20 @@
+{
+  "type": "FeatureCollection",
+  "features": [
+    {
+      "type": "Feature",
+      "properties": {},
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [-0.703125, 24.84656534821976],
+            [11.25, 24.84656534821976],
+            [11.25, 31.353636941500987],
+            [-0.703125, 31.353636941500987]
+          ]
+        ]
+      }
+    }
+  ]
+}