Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with scipy >=1.3.0 #8

Open
hanslovsky opened this issue Jun 3, 2019 · 4 comments
Open

Not compatible with scipy >=1.3.0 #8

hanslovsky opened this issue Jun 3, 2019 · 4 comments

Comments

@hanslovsky
Copy link

SciPy had breaking changes (without increasing the major version!!!) and previously deprecated aliases from scipy.misc were removed:

>>> import malis
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hanslovskyp/my-experiment/0/conda-env/lib/python3.6/site-packages/malis/__init__.py", line 1, in <module>
    from .malis import *
  File "malis/malis.pyx", line 3, in init malis.malis
ImportError: cannot import name comb

Two possible solutions:

  1. Update all affected import statements and set minimum version requirement for scipy dependency
  2. Set upper bound for scipy dependency

I think (1) is a better solution. I currently do not have the time for a PR (maybe in three weeks), but this could be helpful for others who observe the same issue.

hanslovsky added a commit to saalfeldlab/eqip that referenced this issue Jun 3, 2019
hanslovsky added a commit to saalfeldlab/eqip that referenced this issue Jun 3, 2019
@Paragjain10
Copy link

the same thing is not working for me.

I installed scipy==1.3.0 but getting the same error

@hanslovsky
Copy link
Author

@Paragjain10 try installing scipy<1.3.0

@Paragjain10
Copy link

Thank you, this worked

@Joohyeon-Jacob
Copy link

@Paragjain10 try installing scipy<1.3.0

even after following the guide, still same error above occur. Anything else I could do?
From pip list, regarding scipy and scikit:

scikit-image                0.19.3
scikit-learn                1.0.2
scipy                       1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants