Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables should be capitalized #21021

Open
1 task done
adityapatadia opened this issue Sep 17, 2024 · 3 comments
Open
1 task done

Environment variables should be capitalized #21021

adityapatadia opened this issue Sep 17, 2024 · 3 comments
Labels

Comments

@adityapatadia
Copy link

Issue Summary

When using secrets manager like https://www.doppler.com/ the ENV variables are always enforced to be uppercase. It's always best practice to uppercase env variables to ensure compatibility across different shells.

Steps to Reproduce

Try to set uppercase env variable and it does not work.

Ghost Version

5.94

Node.js Version

20

How did you install Ghost?

Docker

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 17, 2024
Copy link
Contributor

sagzy commented Sep 18, 2024

Hey adityapatadia, thanks for raising the issue.

So that I understand your use case better, can you give an example of an env. variable that you'd like to set to uppercase?

@adityapatadia
Copy link
Author

I meant any config that can be set with ENV variable. Take this example database__connection__password. If this is uppercase, Ghost does not recognise it. Ideally it should be possible.

Copy link
Contributor

sagzy commented Sep 18, 2024

Got it, thank you for clarifying!

@sagzy sagzy added the P4 - Low label Sep 18, 2024 — with Linear
@sagzy sagzy removed the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants