Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pylint Version and Review Required Disable Statements #2359

Open
GiulioZizzo opened this issue Dec 18, 2023 · 0 comments
Open

Upgrade Pylint Version and Review Required Disable Statements #2359

GiulioZizzo opened this issue Dec 18, 2023 · 0 comments
Labels
improvement Improve implementation
Milestone

Comments

@GiulioZizzo
Copy link
Collaborator

The current version of pylint on the CI pipeline (2.12.2) requires several ignore statements which are not needed by newer pylint versions (e.g. 2.17, 3.0.3, etc).

For example, a common pattern in ART is to use a # pylint: disable=W0221 for when the number of parameters change in a method between the parent and child classes. However, this suppression is not needed for newer pylint versions as long as a default argument is supplied. There are also examples of unneeded disable comments in the tensorflow derandamized smoothing ablator.

We propose to increase the pylint version and see how many of the existing pylint disable comments are required under the newer tools.

@beat-buesser beat-buesser added the improvement Improve implementation label Jan 9, 2024
@beat-buesser beat-buesser added this to the ART 1.18.0 milestone Jan 9, 2024
@beat-buesser beat-buesser modified the milestones: ART 1.18.0, ART 1.19.0 Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

No branches or pull requests

2 participants