Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui Crash beyond repair #8419

Closed
Macphesto opened this issue Jan 27, 2025 · 6 comments
Closed

Gui Crash beyond repair #8419

Macphesto opened this issue Jan 27, 2025 · 6 comments
Milestone

Comments

@Macphesto
Copy link

Hi! I was using Tribler and THIS happened! 😢

Failed to execute 'querySelectorAll' on 'Document': The provided selector is empty.
SyntaxError: Failed to execute 'querySelectorAll' on 'Document': The provided selector is empty.
    at Object.querySingleReplySelector (<anonymous>:17336:2670)
    at Object.elementSelector (<anonymous>:17336:2875)
    at Object.elementVisible (<anonymous>:17336:936)
    at Object.filterListFallback (<anonymous>:17336:13205)
    at Object._start (<anonymous>:17336:6020)
@qstokkink qstokkink added this to the 8.1.0 milestone Jan 28, 2025
@qstokkink
Copy link
Contributor

Thanks for the report! The fix for this issue is not obvious: we need more information. Could you tell us what web browser and Tribler version you are using?

@Macphesto
Copy link
Author

using Duck Duck browser and latest Tribler 8.07

@qstokkink
Copy link
Contributor

Looking at our compiled index.js, we only have three instances of document.querySelectorAll, two of which are unique:

  1. document.querySelectorAll('link[rel="modulepreload"]')
  2. document.querySelectorAll("[data-radix-focus-guard]") (appears twice)

These both seem to be buried in our dependencies and I expected to find other people with similiar issues. However, I'm not finding anyone with a similar issue in my Google searches.

@qstokkink
Copy link
Contributor

qstokkink commented Jan 28, 2025

I just noticed that the line number 17336 is way bigger than the 339 lines of our source code. This error is actually happening within the DuckDuck browser.

elementSelector is calling querySingleReplySelector here: https://github.com/duckduckgo/autoconsent/blob/94fa72e2bcbd985a34dbfcc4001807fe4fb8d68b/lib/dom-actions.ts#L150

elementVisible is calling elementSelector here: https://github.com/duckduckgo/autoconsent/blob/94fa72e2bcbd985a34dbfcc4001807fe4fb8d68b/lib/dom-actions.ts#L29C27-L29C43

filterListFallback is calling elementVisible here: https://github.com/duckduckgo/autoconsent/blob/94fa72e2bcbd985a34dbfcc4001807fe4fb8d68b/lib/web.ts#L556

This suggests that the passed selectors (getFilterlistSelectors(cosmeticStyles)) are empty.

Currently, this seems like a DuckDuck browser "autoconsent" bug.

@qstokkink qstokkink assigned qstokkink and unassigned qstokkink Jan 29, 2025
@qstokkink
Copy link
Contributor

I tried to massage our web page to not trigger this bug in the DuckDuck browser. However, the browser is just too broken.

@Macphesto if possible, I'd try to disable the autoconsent feature. From our side, we can't fix this.

@Macphesto
Copy link
Author

Thank you for trying 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants