Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the /get_allowed_conflations endpoint #267

Open
gaurav opened this issue Jun 17, 2024 · 0 comments
Open

Update the /get_allowed_conflations endpoint #267

gaurav opened this issue Jun 17, 2024 · 0 comments

Comments

@gaurav
Copy link
Contributor

gaurav commented Jun 17, 2024

We have a /get_allowed_conflations endpoints that is currently hardcoded to return GeneProtein. I think the plan was to generalize the conflation features (#130) so that we could return a set of codes that could be used to turn on various conflations (e.g. /get_normalized_nodes?conflation=GeneProtein). Once we close #130 this won't be needed, but maybe until then we should remove this endpoint or add DrugChemical to the list?

Endpoint: https://nodenormalization-sri.renci.org/docs#/default/get_conflations_get_allowed_conflations_get

@app.get(
"/get_allowed_conflations",
summary="Get the available conflations",
description="The returned strings can be included in an option to /get_normalized_nodes",
)
async def get_conflations() -> ConflationList:
"""
Get implemented conflations
"""
# TODO: build from config instead of hard-coding.
conflations = ConflationList(conflations=["GeneProtein"])
return conflations

@gaurav gaurav added this to the NodeNorm - not urgent milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant