You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While PR #231 fixed #229, it also introduced an odd change in NodeNorm's behavior: while we were previously not including any attributes in the resulting node_bindings, the fixed code now includes information content as well as potentially other attributes in the results node bindings. Here is some example output from babel-validation:
@uhbrar has requested that attributes passed in should be kept in results.[].node_bindings but new attributes should not be added. Note that IC values are also included in theknowledge_graph -- those should continue to be included. The relevant code is linked below:
While PR #231 fixed #229, it also introduced an odd change in NodeNorm's behavior: while we were previously not including any attributes in the resulting
node_bindings
, the fixed code now includes information content as well as potentially other attributes in the results node bindings. Here is some example output from babel-validation:@uhbrar has requested that attributes passed in should be kept in
results.[].node_bindings
but new attributes should not be added. Note that IC values are also included in theknowledge_graph
-- those should continue to be included. The relevant code is linked below:NodeNormalization/node_normalizer/normalizer.py
Lines 96 to 111 in 029f3b9
The text was updated successfully, but these errors were encountered: