-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adapter trait with optional async #5
Comments
does the |
Yes, it is a good idea, but it implies to also apply |
This would be awesome to have! Really enjoy the work you are doing on this |
I think there may be scenes that require both async and sync. |
Sure, the compatibility with previous sync code and the possibility to use both are my main blocking points to move on on this feature. socket.emit("test", ()); // default sync behavior that will emit only from this node.
socket.async().emit("test", ()).await; // async behavior shared between nodes. Other possibilities are:
|
The PR #395 solves the async adapter issues. However before merging this to the main branch I want to be sure that we have a stable trait for all the adapter implementations. Therefore the PR #395 will be merged on the feat-adapter-rework branch. And the adapter implementions should be worked on this branch. I would like to have at least 2 implementations (maybe redis and mongo before merging everything to main and making a release). Currently the @torto once PR #395 is merged, would you still like to work on a Mongo adapter (See issue #361)?. I will personnally try to work on a Redis adapter. |
Hello @Totodore I can work on that adpter for sure, I will start today have a look. |
Make a version of the adapter trait async. This will allow remote adapter implementation (e.g redis adapter, mongodb adapter).
The text was updated successfully, but these errors were encountered: