Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSForestItemData only loading materials on client #175

Open
lukaspj opened this issue May 30, 2020 · 0 comments
Open

TSForestItemData only loading materials on client #175

lukaspj opened this issue May 30, 2020 · 0 comments

Comments

@lukaspj
Copy link
Contributor

lukaspj commented May 30, 2020

This issue was created in the GarageGames Repository (Link to original issue).
The issue was originally created by @DavidWyand-GG and had a total of 0 comments that may contain additional information. The original issue description is pasted below:

Issue #155 was a fix for creating billboards on a dedicated server. This came about because TSForestItemData::_getShapeInstance() is creating a shape instance and always loading the materials. While issue #155 is a good fix, it may be able to be better.

Normally when a shape instance is created the materials are only loaded on the client. TSForestItemData::_getShapeInstance() goes against this and creates the materials regardless of being on the client or server. It appears to do this so it can check if it needs to add the wind effect to the shape.

However, the wind effect should be a client side only effect and I don't believe it needs to be checked on the server. This ticket exists to look into not checking the materials on the server side, and therefore passing in isClient() into the shape creation's loadMaterials flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant