From fdbbfafd455ad8dc3dc9011e7bd6bfc20a31a0f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johan=20Bergstr=C3=B6m?= <johan@topsort.com>
Date: Thu, 5 Sep 2024 15:19:16 +0100
Subject: [PATCH] chore: replace environment variables with `package.json`
 entries

According to `actions/node-setup`, it will read `manifest.engine` values
to decide what node version to use. Second, the lockfile path is only
relevant if it is non-default.
---
 .github/workflows/checkpr.yml        | 8 --------
 .github/workflows/publish-to-npm.yml | 6 ------
 package.json                         | 5 ++++-
 3 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/checkpr.yml b/.github/workflows/checkpr.yml
index c48ff8f..7ee8b8b 100644
--- a/.github/workflows/checkpr.yml
+++ b/.github/workflows/checkpr.yml
@@ -10,10 +10,6 @@ on:
     branches:
       - main
 
-env:
-  lockfile: pnpm-lock.yaml
-  node_version: "18"
-
 # This is to avoid running multiple actions when a PR is updated repeatedly. See
 # https://docs.github.com/en/actions/using-jobs/using-concurrency
 concurrency:
@@ -34,9 +30,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
 
       - name: Install dependencies
         run: pnpm install
@@ -60,9 +54,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
 
       - name: Install dependencies
         run: pnpm install
diff --git a/.github/workflows/publish-to-npm.yml b/.github/workflows/publish-to-npm.yml
index 0e948f3..a10ce70 100644
--- a/.github/workflows/publish-to-npm.yml
+++ b/.github/workflows/publish-to-npm.yml
@@ -4,10 +4,6 @@ on:
   release:
     types: [published]
 
-env:
-  lockfile: pnpm-lock.yaml
-  node_version: "18"
-
 jobs:
   npm-publish:
     name: Publish to NPM
@@ -24,9 +20,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
 
       - name: Install dependencies
         run: pnpm install
diff --git a/package.json b/package.json
index e58a1b5..cbe3a81 100644
--- a/package.json
+++ b/package.json
@@ -4,8 +4,11 @@
   "description": "JS library to automatically report events to Topsort's Analytics",
   "main": "dist/ts.js",
   "type": "module",
-  "packageManager": "pnpm@9.1.1",
+  "packageManager": "pnpm@9.9.0",
   "keywords": ["ads", "sponsored listings", "auctions", "analytics", "topsort"],
+  "engines": {
+    "node": ">=20"
+  },
   "exports": {
     ".": {
       "import": "./dist/ts.mjs",