From 2baae6224f5bf4f17dd267d71c423819e58bd7ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johan=20Bergstr=C3=B6m?= <johan@topsort.com>
Date: Thu, 17 Oct 2024 11:30:51 +0100
Subject: [PATCH] chore: replace environment variables with `package.json`
 entries

According to `actions/node-setup`, it will read `manifest.engine` values to decide what node version to use.
Second, the lockfile path is only relevant if it is non-default.

PR: https://github.com/Topsort/analytics.js/pull/287
Refs: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file
---
 .github/workflows/checkpr.yml        | 10 ++--------
 .github/workflows/publish-to-npm.yml |  7 +------
 package.json                         |  5 ++++-
 3 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/checkpr.yml b/.github/workflows/checkpr.yml
index c48ff8f..18e1e41 100644
--- a/.github/workflows/checkpr.yml
+++ b/.github/workflows/checkpr.yml
@@ -10,10 +10,6 @@ on:
     branches:
       - main
 
-env:
-  lockfile: pnpm-lock.yaml
-  node_version: "18"
-
 # This is to avoid running multiple actions when a PR is updated repeatedly. See
 # https://docs.github.com/en/actions/using-jobs/using-concurrency
 concurrency:
@@ -34,9 +30,8 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
+          node-version-file: package.json
 
       - name: Install dependencies
         run: pnpm install
@@ -60,9 +55,8 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
+          node-version-file: package.json
 
       - name: Install dependencies
         run: pnpm install
diff --git a/.github/workflows/publish-to-npm.yml b/.github/workflows/publish-to-npm.yml
index 0e948f3..61c5da9 100644
--- a/.github/workflows/publish-to-npm.yml
+++ b/.github/workflows/publish-to-npm.yml
@@ -4,10 +4,6 @@ on:
   release:
     types: [published]
 
-env:
-  lockfile: pnpm-lock.yaml
-  node_version: "18"
-
 jobs:
   npm-publish:
     name: Publish to NPM
@@ -24,9 +20,8 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.node_version }}
           cache: pnpm
-          cache-dependency-path: ${{ env.lockfile }}
+          node-version-file: package.json
 
       - name: Install dependencies
         run: pnpm install
diff --git a/package.json b/package.json
index d0535f2..9e586c1 100644
--- a/package.json
+++ b/package.json
@@ -4,8 +4,11 @@
   "description": "JS library to automatically report events to Topsort's Analytics",
   "main": "dist/ts.js",
   "type": "module",
-  "packageManager": "pnpm@9.1.1",
+  "packageManager": "pnpm@9.9.0",
   "keywords": ["ads", "sponsored listings", "auctions", "analytics", "topsort"],
+  "engines": {
+    "node": ">=20.0.0"
+  },
   "exports": {
     ".": {
       "import": "./dist/ts.mjs",