-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more framework targets #20
Comments
Are you referencing the HttpClient nuget package or the one in full framework? 🤔 |
@marko444 generally just adding more targets to a project is a bad practice. Could you provide a list of references in your project and their versions? (so I can repro this) In addition, this library doesn't reference System.Net.Http at all. Both System.Buffers and System.Xml.XmlSerializer are currently required for all projects. System.Buffers hasn't been included in full framework yet; however, I'm thinking about dropping the System.Xml.Serializer dependency.
|
@marko444 There's some new guidance since netstandard1.6 is now depreciated, so I'm going to update this weekend to multi-target. |
Your current targets are:
netstandard1.3;net45
Would it be possible to add also net471, netstandard2.0 ?
I tried including your latest beta nuget into my net471 project and got some unexpected warnings.
Warning Found conflicts between different versions of "System.Net.Http" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed.
Dependencies System.Buffers and System.Xml.XmlSerializer both got included but they shouldn't?
The text was updated successfully, but these errors were encountered: