Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more framework targets #20

Open
marko444 opened this issue May 25, 2018 · 3 comments
Open

Add more framework targets #20

marko444 opened this issue May 25, 2018 · 3 comments

Comments

@marko444
Copy link

marko444 commented May 25, 2018

Your current targets are:
netstandard1.3;net45

Would it be possible to add also net471, netstandard2.0 ?

I tried including your latest beta nuget into my net471 project and got some unexpected warnings.
Warning Found conflicts between different versions of "System.Net.Http" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed.
Dependencies System.Buffers and System.Xml.XmlSerializer both got included but they shouldn't?

@clarkis117
Copy link
Collaborator

Are you referencing the HttpClient nuget package or the one in full framework? 🤔

@clarkis117
Copy link
Collaborator

clarkis117 commented May 26, 2018

@marko444 generally just adding more targets to a project is a bad practice. Could you provide a list of references in your project and their versions? (so I can repro this) In addition, this library doesn't reference System.Net.Http at all.

Both System.Buffers and System.Xml.XmlSerializer are currently required for all projects. System.Buffers hasn't been included in full framework yet; however, I'm thinking about dropping the System.Xml.Serializer dependency.

<ItemGroup> <PackageReference Include="System.Buffers" Version="4.4.0" /> <PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" /> </ItemGroup>

@clarkis117
Copy link
Collaborator

@marko444 There's some new guidance since netstandard1.6 is now depreciated, so I'm going to update this weekend to multi-target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants