Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused-protected #143

Closed
staabm opened this issue Dec 13, 2024 · 4 comments
Closed

unused-protected #143

staabm opened this issue Dec 13, 2024 · 4 comments

Comments

@staabm
Copy link
Contributor

staabm commented Dec 13, 2024

hey,

we are wondering whether this lib could easily support protected methods, since we already have all the machinery in place.

wdyt about also checking protected methods regarding unused stuff?

(private methods are already checked by PHPStan core)

Greetz

@TomasVotruba
Copy link
Owner

TomasVotruba commented Dec 13, 2024

Hey,
I personally use finalize + PHPStan + Rector to spot these.
How complex would it be? :)

@staabm
Copy link
Contributor Author

staabm commented Dec 13, 2024

I will try to implement it so we can have look

in our legacy cases we have some inheritance which we cannot re-work to finalize and stuff (while new code also tries to enforce finalize)

@staabm
Copy link
Contributor Author

staabm commented Dec 16, 2024

POC in #144

@TomasVotruba
Copy link
Owner

TomasVotruba commented Jan 4, 2025

Closing as won't implement: #144 (comment)

Let's keep it simple :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants