Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all top-level properties in model_defaults #3599

Open
eakmanrq opened this issue Jan 8, 2025 · 0 comments · May be fixed by #3696
Open

Support all top-level properties in model_defaults #3599

eakmanrq opened this issue Jan 8, 2025 · 0 comments · May be fixed by #3696
Assignees
@themisvaltinos
Labels
Improvement Improves existing functionality

Comments

@eakmanrq
Copy link
Contributor

eakmanrq commented Jan 8, 2025

Currently some top level properties are supported but it would be ideal to support all of them by default. One thing to consider when adding this is that users need a way to "unset" a default value. So for example set it to "None" and disable the model_defaults value.
@eakmanrq eakmanrq added the Improvement Improves existing functionality label Jan 8, 2025
@themisvaltinos themisvaltinos self-assigned this Jan 16, 2025
@themisvaltinos themisvaltinos linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@themisvaltinos themisvaltinos

Labels
Improvement Improves existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Support top level properties in model_defaults TobikoData/sqlmesh
2 participants
@eakmanrq @themisvaltinos