Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to sqlmesh plan to use rendered model queries for diffing #1254

Open
izeigerman opened this issue Aug 1, 2023 · 2 comments · May be fixed by #3691
Open

Add an option to sqlmesh plan to use rendered model queries for diffing #1254

izeigerman opened this issue Aug 1, 2023 · 2 comments · May be fixed by #3691
Labels
Improvement Improves existing functionality

Comments

@izeigerman
Copy link
Member

This should help investigate issues which occur due to non-deterministic nature of some macros which result in unexpected creation of new model snapshots.
@izeigerman izeigerman added the Improvement Improves existing functionality label Aug 1, 2023
@crericha
Copy link
Contributor

crericha commented Aug 1, 2023

Should we automatically diff the rendered models if there is no diff between the raw models? And say something like raw models match, showing rendered diff.

@giovannipcarvalho giovannipcarvalho mentioned this issue Sep 10, 2024
Open
@tobymao
Copy link
Contributor

tobymao commented Dec 19, 2024

@VaggelisD this seems pretty easy.

we need to add an option to sqlmesh plan

in render_definition.py, we need the option to propagate to call render_query() and render_pre/post_statements

@VaggelisD VaggelisD linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Improves existing functionality
Projects
SQLMesh Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add plan option to show rendered model diff TobikoData/sqlmesh
3 participants
@izeigerman @tobymao @crericha