Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add a configurable time before an offline player stops adding to factions power #104

Open
Josh65-2201 opened this issue Jan 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Josh65-2201
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current issue is that factions will lose all the power and go into the negative when they are sleeping which is unfair especially with multi time zone players in one faction compared to a single player.

Describe the solution you'd like
Add a config option for time allowed offline default to 24 hours. The database can save the exit date and time of the user and when it's past the config time that player will stop giving power.

@Josh65-2201 Josh65-2201 added the enhancement New feature or request label Jan 17, 2024
@ToberoCat
Copy link
Owner

This is already configurable.

    # Configure how long a player counts as active.
    inactive:
      unit: DAYS # The time unit this value will be interpreted as. Some more common possibilities are: SECONDS, MINUTES, HOURS and DAYS
      value: 7

These are the default values for it. They will make sure that players only count as inactive if they are:

  • Not online
  • Haven't been on the server for at least 7 days

I'll leave this issue open, maybe I missed something

@Josh65-2201
Copy link
Contributor Author

Josh65-2201 commented Apr 1, 2024

I have it set to 7 but it doesn't work. If I'm offline for 1 day my power is -50/50

@ToberoCat
Copy link
Owner

I see, right now, this threshold only applies for the inactive extra cost. You won't gain any power nor lose some for the inactive player, the negative value comes from the claim cost being subtracted (Which will be more than you gain when nobody is online)

@Josh65-2201
Copy link
Contributor Author

Could the claim cost be included in the delay or as a option to have it follow the inactive value in the config?

@ToberoCat
Copy link
Owner

Claim cost is something permanent. I'll just make players count as online if they have been online the last 24h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants