Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow regex exclusion rule for mixed-signal extra ports check #19

Open
dlmiles opened this issue May 31, 2024 · 0 comments
Open

Comments

@dlmiles
Copy link
Contributor

dlmiles commented May 31, 2024

I would be nice to allow the setup in GHA of a setting that was a regex to allow additional ports to exists in LEF without causing a pre-check failure. Which I believe will just be ignored by the automation processes. Maybe mitigate them to a warning.

At the moment have to build a special TCL procedure to remove ports, before GDS/LEF creation, then undo the port removal action, to restore the working project back to having the extra ports. Or alternatively, write a script to checkout the project, process in the way TT GHA need, push, which is separate Ci process from how and where the project will actually be managed. This is not good for anyone trying to work with the project in the future.

In my case maybe I'd configure in GHA workflow:

  env:
    TT_IGNORE_PORTS: '^oa_.*$'

The exclusion would never be allowed to exclude the TT_UM interface port requirements, just convert the current ERROR into a WARNING when it notices the existence of extra ports, but still allow check to succeed.

ERROR: Unexpected pin oa_ctrl[0] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[10] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[11] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[12] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[13] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[14] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[15] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[1] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[2] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[3] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[4] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[5] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[6] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[7] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[8] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ctrl[9] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_ena in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_por[0] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Unexpected pin oa_por[1] in /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.lef
ERROR: Precheck failed for /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt_submission/tt_um_dlmiles_schmitt_playground.gds! 😭
ERROR: See /home/runner/work/tt07-schmitt-playground/tt07-schmitt-playground/tt/precheck/reports for more details
ERROR: Markdown report:
# Tiny Tapeout Precheck Results

| Check | Result |
|-----------|--------|
| Magic DRC | ✅ |
| KLayout FEOL | ❌ Fail: Klayout feol failed with 1 DRC violations |
| KLayout BEOL | ✅ |
| KLayout offgrid | ✅ |
| KLayout pin label overlapping drawing | ✅ |
| KLayout zero area | ✅ |
| KLayout Checks | ✅ |
| Pin check | ❌ Fail: Some ports are missing or have wrong dimensions, see 19 LEF errors above |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant