From ce69fc79a85871ca31de3df38f473a536219d93f Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Thu, 7 Apr 2022 17:10:39 +0300
Subject: [PATCH 1/6] do not index .venv

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index e73c109..8f1f772 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
 .idea
 /libvirt_exporter
 libvirt-exporter
+.venv

From 2f6cd9e58a28af83441cc4c442c6e293e1df8f32 Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Fri, 8 Apr 2022 16:45:10 +0300
Subject: [PATCH 2/6] create e2e tests

---
 ansible/README.md                     |  63 +++++++++++++++
 ansible/molecule/default/converge.yml |  36 +++++++++
 ansible/molecule/default/molecule.yml |  15 ++++
 ansible/molecule/default/pool.xml.j2  |  17 ++++
 ansible/molecule/default/prepare.yml  |  91 +++++++++++++++++++++
 ansible/molecule/default/verify.yml   |  52 ++++++++++++
 ansible/molecule/default/vm.xml.j2    | 109 ++++++++++++++++++++++++++
 ansible/requirements.txt              |  70 +++++++++++++++++
 ansible/requirements.yml              |   8 ++
 9 files changed, 461 insertions(+)
 create mode 100644 ansible/README.md
 create mode 100644 ansible/molecule/default/converge.yml
 create mode 100644 ansible/molecule/default/molecule.yml
 create mode 100644 ansible/molecule/default/pool.xml.j2
 create mode 100644 ansible/molecule/default/prepare.yml
 create mode 100644 ansible/molecule/default/verify.yml
 create mode 100644 ansible/molecule/default/vm.xml.j2
 create mode 100644 ansible/requirements.txt
 create mode 100644 ansible/requirements.yml

diff --git a/ansible/README.md b/ansible/README.md
new file mode 100644
index 0000000..cd4a54a
--- /dev/null
+++ b/ansible/README.md
@@ -0,0 +1,63 @@
+END 2 END tests
+---------------
+
+Tested on:
+- macOS: 12.3.1
+- Vagrant: 2.2.19
+- VMware Fusion: 12.2.3
+
+Installation
+============
+
+Prerequisites (Instructions for macOS):
+- VMware Fusion (personal license): https://customerconnect.vmware.com/web/vmware/evalcenter?p=fusion-player-personal
+- Vagrant: https://www.vagrantup.com/downloads
+- VMware Fusion provider for vagrant: https://www.vagrantup.com/docs/providers/vmware/installation
+- Vagrant VMware Utility: https://www.vagrantup.com/docs/providers/vmware/vagrant-vmware-utility
+
+Ansible, molecule installation:
+- create venv: ```cd ansible; mkdir .venv; python3 -m venv .venv```
+- update pip: ```source .venv/bin/activate; pip3 install -U pip```
+- install pip packages: ```pip install -r requirements.txt```
+
+Ansible roles, collection installation:
+- enter venv: ```source .venv/bin/activate```
+- install roles,collections: ```ansible-galaxy role install -r requirements.yml```
+- install collections: ```ansible-galaxy collection install -r requirements.yml```
+
+Usage
+=====
+
+All commands must be executed inside venv.
+
+Create test environment: ```molecule converge```
+Run tests: ```molecule verify```
+
+Contribute
+==========
+
+All tests located in verify playbook inside molecule tree. You can use variable ```libvirt_exporter_metrics``` to querry specific metrics and their values. Example:
+
+```yaml
+    - name: Assert that 'libvirt_up 1' in metrics
+      assert:
+        that: "'libvirt_up 1' in libvirt_exporter_metrics"
+```
+
+In this example, we use assert ansible module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/assert_module.html) to verify that string ```libvirt_up 1``` is present in libvirt-exporter response.
+
+Architecture
+============
+
+There are several main components of e2e tests:
+- environment configuration
+- source code (or artifacts) transfer to this environment
+- service execution
+- conditional checks (tests)
+
+In this realization next set of instruments were selected:
+- fusion
+- molecule + vagrant
+- ansible
+
+Fusion is convinient, local and versatile vm player. 
\ No newline at end of file
diff --git a/ansible/molecule/default/converge.yml b/ansible/molecule/default/converge.yml
new file mode 100644
index 0000000..d7a032c
--- /dev/null
+++ b/ansible/molecule/default/converge.yml
@@ -0,0 +1,36 @@
+---
+
+- name: Converge
+  hosts: all
+  become: True
+  vars:
+    image_name: "localhost/alekseizakharov/libvirt-exporter:latest"
+    sources_remote_path: "/srv/sources"
+    sources_local_path: "{{ playbook_dir }}/../../../"
+  tasks:
+    - name: Copy local sources to remote dir
+      ansible.posix.synchronize:
+        src: "{{ sources_local_path }}"
+        dest: "{{ sources_remote_path }}"
+        rsync_opts:
+          - "--no-motd"
+          - "--exclude=.venv"
+
+    - name: Build libvirt-exporter image
+      containers.podman.podman_image:
+        name: "{{ image_name }}"
+        path: "{{ sources_remote_path }}"
+        build:
+          format: docker
+          annotation:
+            app: libvirt-exporter
+            info: metrics exporter for libvirt
+
+    - name: Run libvirt-exporter container
+      containers.podman.podman_container:
+        name: libvirt_exporter
+        image: "{{ image_name }}"
+        state: started
+        recreate: true
+        publish: "9177:9177"
+        volume: "/var/run/libvirt:/var/run/libvirt"
diff --git a/ansible/molecule/default/molecule.yml b/ansible/molecule/default/molecule.yml
new file mode 100644
index 0000000..913964f
--- /dev/null
+++ b/ansible/molecule/default/molecule.yml
@@ -0,0 +1,15 @@
+---
+
+prerun: False
+driver:
+  name: vagrant
+platforms:
+  - name: ubuntu
+    box: generic/ubuntu2010
+    config_options:
+      ssh.keep_alive: True
+      ssh.remote_user: 'vagrant'
+provisioner:
+  name: ansible
+verifier:
+  name: ansible
\ No newline at end of file
diff --git a/ansible/molecule/default/pool.xml.j2 b/ansible/molecule/default/pool.xml.j2
new file mode 100644
index 0000000..488ff09
--- /dev/null
+++ b/ansible/molecule/default/pool.xml.j2
@@ -0,0 +1,17 @@
+<pool type='dir'>
+  <name>vms</name>
+  <uuid>28954164-9810-47bc-88f7-ab3d847c38df</uuid>
+  <capacity unit='bytes'>66844176384</capacity>
+  <allocation unit='bytes'>6587465728</allocation>
+  <available unit='bytes'>60256710656</available>
+  <source>
+  </source>
+  <target>
+    <path>/var/lib/libvirt/images</path>
+    <permissions>
+      <mode>0711</mode>
+      <owner>0</owner>
+      <group>0</group>
+    </permissions>
+  </target>
+</pool>
\ No newline at end of file
diff --git a/ansible/molecule/default/prepare.yml b/ansible/molecule/default/prepare.yml
new file mode 100644
index 0000000..d067008
--- /dev/null
+++ b/ansible/molecule/default/prepare.yml
@@ -0,0 +1,91 @@
+---
+
+- name: Configure test vm
+  hosts: all
+  become: True
+  gather_facts: True
+  tasks:
+    - name: Install libvirtd
+      apt:
+        name: "{{ item.name }}={{ item.version }}"
+        update_cache: True
+      loop:
+        - name: libvirt-daemon
+          version: "6.6.0-1ubuntu3.5"
+        - name: libvirt-daemon-system
+          version: "6.6.0-1ubuntu3.5"
+        - name: libguestfs-tools
+          version: "1:1.42.0-9ubuntu1"
+        - name: virtinst
+          version: "1:2.2.1-4ubuntu2"
+        - name: python3-libvirt
+          version: "6.1.0-1"
+        - name: python3-lxml
+          version: "4.5.2-1ubuntu0.4"
+        - name: podman
+          version: "2.0.6+dfsg1-1ubuntu1.2"
+        - name: runc
+          version: "1.0.0~rc95-0ubuntu1~20.10.1"
+
+    - name: Download prom2json
+      get_url:
+        url: 'https://github.com/prometheus/prom2json/releases/download/v1.3.0/prom2json-1.3.0.linux-amd64.tar.gz'
+        dest: /home/vagrant/prom2json-1.3.0.linux-amd64.tar.gz
+
+    - name: Unpack prom2json
+      ansible.builtin.unarchive:
+        remote_src: True
+        src: /home/vagrant/prom2json-1.3.0.linux-amd64.tar.gz
+        dest: /home/vagrant
+
+    - name: Install prom2json
+      copy: 
+        remote_src: True
+        mode: '777'
+        src: /home/vagrant/prom2json-1.3.0.linux-amd64/prom2json
+        dest: /usr/local/bin/prom2json
+
+    - name: List libvirt volume pools
+      community.libvirt.virt_pool:
+        command: list_pools
+      register: libvirt_pools
+
+    - name: Create default libvirtd volume pool
+      community.libvirt.virt_pool:
+        command: define
+        name: vms
+        xml: '{{ lookup("template", "pool.xml.j2") }}'
+      when: "'default' not in libvirt_pools.list_pools"
+
+    - name: Build vms pool
+      community.libvirt.virt_pool:
+        command: build
+        name: vms
+      when: "'vms' not in libvirt_pools.list_pools"
+
+    - name: Create vms pool
+      community.libvirt.virt_pool:
+        state: active
+        name: vms
+      when: "'vms' not in libvirt_pools.list_pools"
+
+    - name: Download qcow2 vm
+      get_url:
+        url: http://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img
+        dest: /home/vagrant/cirros-0.4.0-x86_64-disk.qcow2
+
+    - name: Create volume
+      command: virsh vol-create-as vms cirros-image.qcow2 128M --format qcow2
+
+    - name: Upload image contents to volume    
+      command: virsh vol-upload cirros-image.qcow2 /home/vagrant/cirros-0.4.0-x86_64-disk.qcow2 --pool vms
+
+    - name: Define vm
+      community.libvirt.virt:
+        command: define
+        xml: "{{ lookup('template', 'vm.xml.j2') }}"
+
+    - name: Create vm
+      community.libvirt.virt:
+        name: test-instance
+        state: running
diff --git a/ansible/molecule/default/verify.yml b/ansible/molecule/default/verify.yml
new file mode 100644
index 0000000..bbcc3bd
--- /dev/null
+++ b/ansible/molecule/default/verify.yml
@@ -0,0 +1,52 @@
+---
+
+- name: Verify
+  hosts: all
+  become: True
+  gather_facts: True
+  vars:
+    libvirt_exporter_url: "http://localhost:9177/metrics"
+  tasks:
+    - name: Assert that libvirt_exporter is serving
+      uri:
+        url: "{{ libvirt_exporter_url }}"
+        status_code: 200
+
+    - name: Get /metrics content from libvirt_eporter
+      command: "prom2json {{ libvirt_exporter_url }}"
+      register: libvirt_exporter_response
+
+    - name: Prettify libvirt_exporter_result
+      set_fact:
+        libvirt_exporter_metrics: "{{ libvirt_exporter_response.stdout | from_json }}"
+
+    - name: Assert that 'libvirt_up' in metrics
+      assert:
+        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_up') | first"
+
+    - name: Assert that libvirt_up metric has necessary type
+      vars:
+        libvirt_up_metric: "{{ libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_up') | first }}"
+      block:
+        - name: Assert that libvirt_up metric has necessary type
+          assert:
+            that: "libvirt_up_metric.type == 'GAUGE'"
+
+    - name: Assert that 'libvirt_domain_block_meta' in metrics
+      assert:
+        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_domain_block_meta') | first"
+
+    - name: Assert that libvirt_domain_block_meta metric has necessary attributes
+      vars:
+        libvirt_domain_block_meta: "{{ libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_domain_block_meta') | first }}"
+        libvirt_domain_block_meta_metrics: "{{ libvirt_domain_block_meta.metrics | first }}"
+      block:
+        - name: Assert that libvirt_domain_block_meta metric has necessary type
+          assert:
+            that: "libvirt_domain_block_meta.type == 'GAUGE'"
+        - name: Assert libvirt_domain_block_meta labels
+          assert:
+            that: |
+              (libvirt_domain_block_meta_metrics.labels.bus == 'virtio')
+              and
+              (libvirt_domain_block_meta_metrics.labels.disk_type == 'file')
diff --git a/ansible/molecule/default/vm.xml.j2 b/ansible/molecule/default/vm.xml.j2
new file mode 100644
index 0000000..a63822b
--- /dev/null
+++ b/ansible/molecule/default/vm.xml.j2
@@ -0,0 +1,109 @@
+<domain type='qemu'>
+  <name>test-instance</name>
+  <memory unit='KiB'>524288</memory>
+  <currentMemory unit='KiB'>524288</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <resource>
+    <partition>/machine</partition>
+  </resource>
+  <os>
+    <type arch='x86_64' machine='pc-i440fx-groovy'>hvm</type>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+  </features>
+  <cpu mode='custom' match='exact' check='full'>
+    <model fallback='forbid'>qemu64</model>
+    <feature policy='require' name='hypervisor'/>
+    <feature policy='require' name='lahf_lm'/>
+  </cpu>
+  <clock offset='utc'>
+    <timer name='rtc' tickpolicy='catchup'/>
+    <timer name='pit' tickpolicy='delay'/>
+    <timer name='hpet' present='no'/>
+  </clock>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <pm>
+    <suspend-to-mem enabled='no'/>
+    <suspend-to-disk enabled='no'/>
+  </pm>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <disk type='file' device='disk'>
+      <driver name='qemu' type='qcow2'/>
+      <source file='/var/lib/libvirt/images/cirros-image.qcow2' index='1'/>
+      <backingStore/>
+      <target dev='vda' bus='virtio'/>
+      <alias name='virtio-disk0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
+    </disk>
+    <controller type='usb' index='0' model='ich9-ehci1'>
+      <alias name='usb'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x7'/>
+    </controller>
+    <controller type='usb' index='0' model='ich9-uhci1'>
+      <alias name='usb'/>
+      <master startport='0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0' multifunction='on'/>
+    </controller>
+    <controller type='usb' index='0' model='ich9-uhci2'>
+      <alias name='usb'/>
+      <master startport='2'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x1'/>
+    </controller>
+    <controller type='usb' index='0' model='ich9-uhci3'>
+      <alias name='usb'/>
+      <master startport='4'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x2'/>
+    </controller>
+    <controller type='pci' index='0' model='pci-root'>
+      <alias name='pci.0'/>
+    </controller>
+    <interface type='network'>
+      <mac address='52:54:00:4a:cb:47'/>
+      <source network='default' portid='33094b86-84db-447a-8615-6bc37493972b' bridge='virbr0'/>
+      <target dev='vnet0'/>
+      <model type='e1000'/>
+      <alias name='net0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
+    </interface>
+    <serial type='pty'>
+      <source path='/dev/pts/1'/>
+      <target type='isa-serial' port='0'>
+        <model name='isa-serial'/>
+      </target>
+      <alias name='serial0'/>
+    </serial>
+    <console type='pty' tty='/dev/pts/1'>
+      <source path='/dev/pts/1'/>
+      <target type='serial' port='0'/>
+      <alias name='serial0'/>
+    </console>
+    <input type='tablet' bus='usb'>
+      <alias name='input0'/>
+      <address type='usb' bus='0' port='1'/>
+    </input>
+    <input type='mouse' bus='ps2'>
+      <alias name='input1'/>
+    </input>
+    <input type='keyboard' bus='ps2'>
+      <alias name='input2'/>
+    </input>
+    <graphics type='vnc' port='5900' autoport='yes' listen='127.0.0.1' keymap='en-us'>
+      <listen type='address' address='127.0.0.1'/>
+    </graphics>
+    <video>
+      <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1' primary='yes'/>
+      <alias name='video0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
+    </video>
+    <memballoon model='virtio'>
+      <alias name='balloon0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
+    </memballoon>
+  </devices>
+</domain>
\ No newline at end of file
diff --git a/ansible/requirements.txt b/ansible/requirements.txt
new file mode 100644
index 0000000..c0d5b68
--- /dev/null
+++ b/ansible/requirements.txt
@@ -0,0 +1,70 @@
+ansible==4.7.0
+ansible-compat==0.5.0
+ansible-core==2.11.6
+ansible-lint==5.2.1
+arrow==1.2.0
+backports.entry-points-selectable==1.1.0
+bcrypt==3.2.0
+binaryornot==0.4.4
+bracex==2.2
+Cerberus==1.3.2
+certifi==2021.10.8
+cffi==1.15.0
+cfgv==3.3.1
+chardet==4.0.0
+charset-normalizer==2.0.7
+click==8.0.3
+click-help-colors==0.9.1
+colorama==0.4.4
+commonmark==0.9.1
+cookiecutter==1.7.3
+cryptography==35.0.0
+distlib==0.3.3
+distro==1.6.0
+docker==5.0.3
+enrich==1.2.6
+filelock==3.3.1
+flake8==4.0.1
+identify==2.3.0
+idna==3.3
+Jinja2==3.0.2
+jinja2-time==0.2.0
+MarkupSafe==2.0.1
+mccabe==0.6.1
+molecule==3.5.2
+molecule-docker==1.0.2
+molecule-vagrant==0.6.3
+nodeenv==1.6.0
+packaging==21.0
+paramiko==2.8.0
+pathspec==0.9.0
+platformdirs==2.4.0
+pluggy==1.0.0
+poyo==0.5.0
+pre-commit==2.15.0
+pycodestyle==2.8.0
+pycparser==2.20
+pyflakes==2.4.0
+Pygments==2.10.0
+PyNaCl==1.4.0
+pyparsing==2.4.7
+python-dateutil==2.8.2
+python-slugify==5.0.2
+python-vagrant==0.5.15
+PyYAML==5.4.1
+requests==2.26.0
+resolvelib==0.5.4
+rich==10.12.0
+ruamel.yaml==0.17.16
+ruamel.yaml.clib==0.2.6
+selinux==0.2.1
+six==1.16.0
+subprocess-tee==0.3.5
+tenacity==8.0.1
+text-unidecode==1.3
+toml==0.10.2
+urllib3==1.26.7
+virtualenv==20.8.1
+wcmatch==8.2
+websocket-client==1.2.1
+yamllint==1.26.3
diff --git a/ansible/requirements.yml b/ansible/requirements.yml
new file mode 100644
index 0000000..8df3859
--- /dev/null
+++ b/ansible/requirements.yml
@@ -0,0 +1,8 @@
+---
+collections:
+
+- name: ansible.posix
+  version: 1.3.0
+
+- name: community.libvirt
+  version: 1.0.2
\ No newline at end of file

From 62c5db6970aa2bd8a7eb6664b1cffa5a3c72e3d1 Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Fri, 8 Apr 2022 16:50:44 +0300
Subject: [PATCH 3/6] fixup! create e2e tests

---
 ansible/README.md                     | 16 ----------------
 ansible/molecule/default/molecule.yml |  2 +-
 ansible/molecule/default/pool.xml.j2  |  2 +-
 ansible/molecule/default/vm.xml.j2    |  2 +-
 4 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/ansible/README.md b/ansible/README.md
index cd4a54a..7c3125b 100644
--- a/ansible/README.md
+++ b/ansible/README.md
@@ -45,19 +45,3 @@ All tests located in verify playbook inside molecule tree. You can use variable
 ```
 
 In this example, we use assert ansible module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/assert_module.html) to verify that string ```libvirt_up 1``` is present in libvirt-exporter response.
-
-Architecture
-============
-
-There are several main components of e2e tests:
-- environment configuration
-- source code (or artifacts) transfer to this environment
-- service execution
-- conditional checks (tests)
-
-In this realization next set of instruments were selected:
-- fusion
-- molecule + vagrant
-- ansible
-
-Fusion is convinient, local and versatile vm player. 
\ No newline at end of file
diff --git a/ansible/molecule/default/molecule.yml b/ansible/molecule/default/molecule.yml
index 913964f..350ece3 100644
--- a/ansible/molecule/default/molecule.yml
+++ b/ansible/molecule/default/molecule.yml
@@ -12,4 +12,4 @@ platforms:
 provisioner:
   name: ansible
 verifier:
-  name: ansible
\ No newline at end of file
+  name: ansible
diff --git a/ansible/molecule/default/pool.xml.j2 b/ansible/molecule/default/pool.xml.j2
index 488ff09..1299ad6 100644
--- a/ansible/molecule/default/pool.xml.j2
+++ b/ansible/molecule/default/pool.xml.j2
@@ -14,4 +14,4 @@
       <group>0</group>
     </permissions>
   </target>
-</pool>
\ No newline at end of file
+</pool>
diff --git a/ansible/molecule/default/vm.xml.j2 b/ansible/molecule/default/vm.xml.j2
index a63822b..3131354 100644
--- a/ansible/molecule/default/vm.xml.j2
+++ b/ansible/molecule/default/vm.xml.j2
@@ -106,4 +106,4 @@
       <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
     </memballoon>
   </devices>
-</domain>
\ No newline at end of file
+</domain>

From 68b4c4e4f0ebe9b94bed08df008538d7a2d94035 Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Fri, 8 Apr 2022 16:52:00 +0300
Subject: [PATCH 4/6] fixup! fixup! create e2e tests

---
 ansible/requirements.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ansible/requirements.yml b/ansible/requirements.yml
index 8df3859..af9cce7 100644
--- a/ansible/requirements.yml
+++ b/ansible/requirements.yml
@@ -5,4 +5,4 @@ collections:
   version: 1.3.0
 
 - name: community.libvirt
-  version: 1.0.2
\ No newline at end of file
+  version: 1.0.2

From 8a01e8a9bc31f65d9697d9f3d40a5a11ad105049 Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Fri, 8 Apr 2022 17:27:48 +0300
Subject: [PATCH 5/6] fixup! fixup! fixup! create e2e tests

---
 ansible/README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ansible/README.md b/ansible/README.md
index 7c3125b..e2f078e 100644
--- a/ansible/README.md
+++ b/ansible/README.md
@@ -39,9 +39,9 @@ Contribute
 All tests located in verify playbook inside molecule tree. You can use variable ```libvirt_exporter_metrics``` to querry specific metrics and their values. Example:
 
 ```yaml
-    - name: Assert that 'libvirt_up 1' in metrics
+    - name: Assert that 'libvirt_up' in metrics
       assert:
-        that: "'libvirt_up 1' in libvirt_exporter_metrics"
+        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_up') | first"
 ```
 
-In this example, we use assert ansible module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/assert_module.html) to verify that string ```libvirt_up 1``` is present in libvirt-exporter response.
+In this example, we use assert ansible module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/assert_module.html) to verify that there is a element in ```libvirt_exporter_metrics``` array with property ```name``` equals to  ```libvirt_up```. ```libvirt_exporter_metrics``` array is a parsed json response from libvirt-exporter.

From 64f1adaf085c31e56b2d6384578137f0d0e733cb Mon Sep 17 00:00:00 2001
From: Nikita Kretov <kretov995@gmail.com>
Date: Sat, 9 Apr 2022 12:52:58 +0300
Subject: [PATCH 6/6] fixup! fixup! fixup! fixup! create e2e tests

---
 ansible/molecule/default/metrics.yml | 205 +++++++++++++++++++++++++++
 ansible/molecule/default/verify.yml  |  35 ++---
 2 files changed, 214 insertions(+), 26 deletions(-)
 create mode 100644 ansible/molecule/default/metrics.yml

diff --git a/ansible/molecule/default/metrics.yml b/ansible/molecule/default/metrics.yml
new file mode 100644
index 0000000..7172ec2
--- /dev/null
+++ b/ansible/molecule/default/metrics.yml
@@ -0,0 +1,205 @@
+---
+
+metrics:
+  - name: go_gc_duration_seconds
+    type: SUMMARY
+  - name: go_goroutines
+    type: GAUGE
+  - name: go_info
+    type: GAUGE
+  - name: go_memstats_alloc_bytes
+    type: GAUGE
+  - name: go_memstats_alloc_bytes_total
+    type: COUNTER
+  - name: go_memstats_buck_hash_sys_bytes
+    type: GAUGE
+  - name: go_memstats_frees_total
+    type: COUNTER
+  - name: go_memstats_gc_cpu_fraction
+    type: GAUGE
+  - name: go_memstats_gc_sys_bytes
+    type: GAUGE
+  - name: go_memstats_heap_alloc_bytes
+    type: GAUGE
+  - name: go_memstats_heap_idle_bytes
+    type: GAUGE
+  - name: go_memstats_heap_inuse_bytes
+    type: GAUGE
+  - name: go_memstats_heap_objects
+    type: GAUGE
+  - name: go_memstats_heap_released_bytes
+    type: GAUGE
+  - name: go_memstats_heap_sys_bytes
+    type: GAUGE
+  - name: go_memstats_last_gc_time_seconds
+    type: GAUGE
+  - name: go_memstats_lookups_total
+    type: COUNTER
+  - name: go_memstats_mallocs_total
+    type: COUNTER
+  - name: go_memstats_mcache_inuse_bytes
+    type: GAUGE
+  - name: go_memstats_mcache_sys_bytes
+    type: GAUGE
+  - name: go_memstats_mspan_inuse_bytes
+    type: GAUGE
+  - name: go_memstats_mspan_sys_bytes
+    type: GAUGE
+  - name: go_memstats_next_gc_bytes
+    type: GAUGE
+  - name: go_memstats_other_sys_bytes
+    type: GAUGE
+  - name: go_memstats_stack_inuse_bytes
+    type: GAUGE
+  - name: go_memstats_stack_sys_bytes
+    type: GAUGE
+  - name: go_memstats_sys_bytes
+    type: GAUGE
+  - name: go_threads
+    type: GAUGE
+  - name: libvirt_domain_block_meta
+    type: GAUGE
+  - name: libvirt_domain_block_stats_allocation
+    type: GAUGE
+  - name: libvirt_domain_block_stats_capacity_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_flush_requests_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_flush_time_seconds_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_limit_burst_length_read_requests_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_length_total_requests_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_length_write_requests_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_read_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_read_bytes_length_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_read_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_total_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_total_bytes_length_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_total_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_write_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_write_bytes_length_seconds
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_burst_write_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_read_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_read_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_total_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_total_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_write_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_limit_write_requests
+    type: GAUGE
+  - name: libvirt_domain_block_stats_physicalsize_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_read_bytes_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_read_requests_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_read_time_seconds_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_size_iops_bytes
+    type: GAUGE
+  - name: libvirt_domain_block_stats_write_bytes_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_write_requests_total
+    type: COUNTER
+  - name: libvirt_domain_block_stats_write_time_seconds_total
+    type: COUNTER
+  - name: libvirt_domain_info_cpu_time_seconds_total
+    type: COUNTER
+  - name: libvirt_domain_info_maximum_memory_bytes
+    type: GAUGE
+  - name: libvirt_domain_info_memory_usage_bytes
+    type: GAUGE
+  - name:  libvirt_domain_info_meta
+    type: GAUGE
+  - name: libvirt_domain_info_virtual_cpus
+    type: GAUGE
+  - name: libvirt_domain_info_vstate
+    type: GAUGE
+  - name: libvirt_domain_interface_meta
+    type: GAUGE
+  - name:  libvirt_domain_interface_stats_receive_bytes_total
+    type: COUNTER
+  - name: libvirt_domain_interface_stats_receive_drops_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_receive_errors_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_receive_packets_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_transmit_bytes_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_transmit_drops_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_transmit_errors_total
+    type: COUNTER
+  - name:  libvirt_domain_interface_stats_transmit_packets_total
+    type: COUNTER
+  - name:  libvirt_domain_memory_stats_actual_balloon_bytes
+    type: GAUGE
+  - name:  libvirt_domain_memory_stats_available_bytes
+    type: GAUGE
+  - name: libvirt_domain_memory_stats_disk_cache_bytes
+    type: GAUGE
+  - name: libvirt_domain_memory_stats_major_fault_total
+    type: COUNTER
+  - name: libvirt_domain_memory_stats_minor_fault_total
+    type: COUNTER
+  - name: libvirt_domain_memory_stats_rss_bytes
+    type: GAUGE
+  - name: libvirt_domain_memory_stats_unused_bytes
+    type: GAUGE
+  - name: libvirt_domain_memory_stats_usable_bytes
+    type: GAUGE
+  - name:  libvirt_domain_memory_stats_used_percent
+    type: GAUGE
+  - name:  libvirt_domain_vcpu_cpu
+    type: GAUGE
+  - name: libvirt_domain_vcpu_state
+    type: GAUGE
+  - name: libvirt_domain_vcpu_time_seconds_total
+    type: COUNTER
+  - name:  libvirt_domain_vcpu_wait_seconds_total
+    type: COUNTER
+  - name:  libvirt_pool_info_allocation_bytes
+    type: GAUGE
+  - name:  libvirt_pool_info_available_bytes
+    type: GAUGE
+  - name:  libvirt_pool_info_capacity_bytes
+    type: GAUGE
+  - name:  libvirt_up
+    type: GAUGE
+  - name:  libvirt_versions_info
+    type: GAUGE
+  - name: process_cpu_seconds_total
+    type: COUNTER
+  - name:  process_max_fds
+    type: GAUGE
+  - name: process_open_fds
+    type: GAUGE
+  - name: process_resident_memory_bytes
+    type: GAUGE
+  - name: process_start_time_seconds
+    type: GAUGE
+  - name: process_virtual_memory_bytes
+    type: GAUGE
+  - name: process_virtual_memory_max_bytes
+    type: GAUGE
+  - name: promhttp_metric_handler_requests_in_flight
+    type: GAUGE
+  - name: promhttp_metric_handler_requests_total
+    type: COUNTER
diff --git a/ansible/molecule/default/verify.yml b/ansible/molecule/default/verify.yml
index bbcc3bd..6e2e567 100644
--- a/ansible/molecule/default/verify.yml
+++ b/ansible/molecule/default/verify.yml
@@ -4,6 +4,8 @@
   hosts: all
   become: True
   gather_facts: True
+  vars_files:
+    - metrics.yml
   vars:
     libvirt_exporter_url: "http://localhost:9177/metrics"
   tasks:
@@ -20,33 +22,14 @@
       set_fact:
         libvirt_exporter_metrics: "{{ libvirt_exporter_response.stdout | from_json }}"
 
-    - name: Assert that 'libvirt_up' in metrics
+    - name: Assert that all metrics are present
       assert:
-        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_up') | first"
+        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', item.name) | length"
+      loop: "{{ metrics }}"
 
-    - name: Assert that libvirt_up metric has necessary type
+    - name: Assert that all metrics metric have necessary type
       vars:
-        libvirt_up_metric: "{{ libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_up') | first }}"
-      block:
-        - name: Assert that libvirt_up metric has necessary type
-          assert:
-            that: "libvirt_up_metric.type == 'GAUGE'"
-
-    - name: Assert that 'libvirt_domain_block_meta' in metrics
+        libvirt_up_metric: "{{ libvirt_exporter_metrics | selectattr('name', 'equalto', item.name) | first }}"
       assert:
-        that: "libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_domain_block_meta') | first"
-
-    - name: Assert that libvirt_domain_block_meta metric has necessary attributes
-      vars:
-        libvirt_domain_block_meta: "{{ libvirt_exporter_metrics | selectattr('name', 'equalto', 'libvirt_domain_block_meta') | first }}"
-        libvirt_domain_block_meta_metrics: "{{ libvirt_domain_block_meta.metrics | first }}"
-      block:
-        - name: Assert that libvirt_domain_block_meta metric has necessary type
-          assert:
-            that: "libvirt_domain_block_meta.type == 'GAUGE'"
-        - name: Assert libvirt_domain_block_meta labels
-          assert:
-            that: |
-              (libvirt_domain_block_meta_metrics.labels.bus == 'virtio')
-              and
-              (libvirt_domain_block_meta_metrics.labels.disk_type == 'file')
+        that: "libvirt_up_metric.type == item.type"
+      loop: "{{ metrics }}"