-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non unique codes - standard/codelists /geoCodeType.csv #391
Comments
@michaelwood There are a couple of issues:
|
Why does geoCodeType have duplicates?geoCodeType is not constrained in the schema and can contain any string. History#29 is how we chose this codelist.
This was not addressed and the codelist was added. Looking at the megalist from Register of Geographic Codes uploaded to drive as (RGC_DECEMBER_2020_UK v2)and the GSS wikipedia page , DuplicatesThere are 46 unique values with 18 duplicates. Duplicate Codes / Entity abbreviations occur because they are repeated for different Entity coverages (One of the 9 - Wales, Channel Islands, Isle of Man, Scotland, England and Wales, England, United Kingdom, Northern Ireland, Great Britain) Here is a table showing the 3 character GSS code prefix, the code the codelist uses (which is an non unique entity abbreviation), the geographic coverage of the code, and the title of the code (name of the entity)
Deduplicating the codelistIf we deduplicate the codelist, there should be no issue, because the geoCode field is unique in itself within the GSS system. Governance - As per https://standard.threesixtygiving.org/en/latest/about/governance/#versions this will be a PATCH Updating the codelistIdeally, the codelist woud use what the GSS calls 'code', the unique 3 character prefix - however, making this change would be a MAJOR change. Updating the codelist within the realm of PATCH means only cleaning up the list. Work to be done before we know how to update the codelist:
|
It seems to me that we have a few options moving forward:
|
This codelist is currently not able to be supported. See ThreeSixtyGiving/standard#391 Backout the work done for this with the aim of creating a draft PR that could revert this commit.
This codelist is currently not able to be supported. See ThreeSixtyGiving/standard#391 Backout the work done for this with the aim of creating a draft PR that could revert this commit.
@michaelwood Katherine agrees that the field is a candidate for deprecation - hence not worth investing effort in updating the list (also this would likely be backwards-incompatible) |
@mariongalley I'll get a branch ready which deprecates the field and updates the description appropriately. How should the Data Quality Tool report on deprecation if this field is used in the data - is it a yellow question mark? |
@neelima-j I don't think we're ready to pull the trigger on deprecating the field yet, but yes it's a good question if we do this, how will the DQT represent it |
Unlike other codelists the list of geoCodeTypes is non unique - there are multiple codes with multiple differing titles/descriptions. I'm not sure how to choose the correct one when trying to display the non-code version when looking at Grant data.
https://github.com/ThreeSixtyGiving/standard/blob/main/codelists/geoCodeType.csv
The text was updated successfully, but these errors were encountered: