Skip to content

Commit 961ba7d

Browse files
Add ehreview config file
1 parent bfd43cf commit 961ba7d

File tree

1 file changed

+52
-0
lines changed

1 file changed

+52
-0
lines changed

.ehreview.yml

+52
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
AllCops:
2+
TargetBranches: &target_branches
3+
- master
4+
5+
# Require reviews for pull requests
6+
# Params:
7+
# + PeerCount : number of required peer approvals
8+
# + Branches : only requires approvals on pull request on these branches as base.
9+
Review::RequireApprovals:
10+
Enabled: true
11+
Required: true
12+
PeerCount: 2
13+
Branches: *target_branches
14+
15+
# Require some checkboxes to be tick in pull request body
16+
# Params:
17+
# + Checkboxes : array of hash describing each checkbox
18+
#
19+
# A checkbox is described by hash with keys:
20+
# + Content : the text following the checkbox
21+
# + Message : the message to comment in PR if the checkbox is not checked
22+
# + Paths : list of filename blobbing strings. Only require this checkbox if changed files match this list.
23+
Review::RequireCheckboxes:
24+
Enabled: false
25+
Required: true
26+
Branches: *target_branches
27+
Checkboxes: []
28+
29+
# Warning when updating models using methods that don't trigger callbacks,
30+
# resulting in not sending Kafka message if model is hooked.
31+
Kafka::UpdateModelWithoutCallbacks:
32+
Enabled: false
33+
34+
# Warning when changing a Kafka message format to ensure not affecting other services
35+
Kafka::MessageChanged:
36+
Enabled: false
37+
38+
Thinkei::ReviewCrossTeam:
39+
Enabled: true
40+
Required: true
41+
42+
Security::TextMatchWarning:
43+
Enabled: false
44+
Rules:
45+
- Name: SensitiveData
46+
FileTypesRegex: !ruby/regexp /.*_serializer\.(rb|rake)/i
47+
IgnoredFileRegex: !ruby/regexp /^(config|test|spec|features)\/.*/i
48+
RegexPattern: !ruby/regexp /.*(mobile_number|email|address).*/i
49+
Title: "Doing something with sensitive data"
50+
Summary: "Please be careful with sensitive data and review this security checklist. https://github.com/Thinkei/employment-hero/wiki/Application-Security-Checklist#preventing-sensitive-logging"
51+
Message: "Beware of security when exposed sensitive data"
52+

0 commit comments

Comments
 (0)