Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade to Rails 7.1 #4735

Closed
2 of 3 tasks
ChargrilledChook opened this issue Aug 10, 2024 · 1 comment · Fixed by #4736 or #4737
Closed
2 of 3 tasks

Chore: Upgrade to Rails 7.1 #4735

ChargrilledChook opened this issue Aug 10, 2024 · 1 comment · Fixed by #4736 or #4737
Assignees
@ChargrilledChook
Labels
ruby Pull requests that update Ruby code Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.

Comments

@ChargrilledChook
Copy link
Member

ChargrilledChook commented Aug 10, 2024 •
edited
Loading

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Chore: brief description of chore format, e.g. Chore: Lesson complete button does not update on click
  • Would you like to work on this issue?

Chore description

Upgrade our Rails version to 7.1.x.x

Acceptance criteria

  • The app is running on Rails 7.1
  • No regressions

Additional Comments

This can potentially be split up into several PR's with a phased approach.

  • First, upgrading the version and ensuring tests still pass
  • Working through the config/initializers/new_framework_defaults_7_1.rb file (this step could be multiple PRs in itself)
  • Finally, changing the framework defaults in config/application.rb to 7.1

Tasks
Beta Give feedback
  3. [DRAFT] Chore: Rails 7.1 Upgrade follow up #4742
    20 of 27
@ChargrilledChook ChargrilledChook added Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. ruby Pull requests that update Ruby code labels Aug 10, 2024
@ChargrilledChook ChargrilledChook mentioned this issue Aug 10, 2024
Closed
2 tasks
@ChargrilledChook ChargrilledChook self-assigned this Aug 10, 2024
ChargrilledChook added a commit that referenced this issue Aug 10, 2024
@ChargrilledChook
Manually fix new unsafe Rubcop offences #4735
c50dfc0 
* Requires fixing some specs as some elements became ambiguous due to
preferring more generic `click_on` Capybara helper instead of `click_link`
and `click_button`
* Solved by searching within `form` - alternatively, we could use
test_ids. Probably a more robust approach, but preferred not having
to touch views for this pass
@ChargrilledChook ChargrilledChook mentioned this issue Aug 10, 2024
Merged
@ChargrilledChook ChargrilledChook linked a pull request Aug 10, 2024 that will close this issue
Upgrade/rails 7.1 v2 #4736
Merged
@ChargrilledChook ChargrilledChook mentioned this issue Aug 10, 2024
Merged
@ChargrilledChook ChargrilledChook linked a pull request Aug 10, 2024 that will close this issue
Chore: Toggle low risk framework defaults for Rails 7.1 #4737
Merged
@ChargrilledChook
Copy link
Member Author

Related PR pointing to main one that toggles the lower risk config changes #4737

ChargrilledChook added a commit that referenced this issue Aug 11, 2024
@ChargrilledChook
Upgrade: Rails version 7.1 (#4735)
8384a65 
This commit:
* Run bundle update
* Run `app:update` task and resolve conflicts in config & env files
* Run safe autocorrect fixes for new Rubocop offences
* Add rubocop-rspec_rails to Rubcop config
* Manually fix new unsafe Rubcop offences
  * Requires fixing some specs as some elements became ambiguous due to
    preferring more generic `click_on` Capybara helper instead of `click_link`
* Add generators to new `autoload_lib` configuration
  * Because: CI breaks otherwise
* Access schema migration object via base connection in Heroku task
  * Because: This behaviour was removed in rails 7.1.
    See https://github.com/rails/rails/blob/7-1-stable/activerecord/CHANGELOG.md
* Toggle low risk framework defaults for Rails 7.1
ChargrilledChook added a commit that referenced this issue Aug 11, 2024
@ChargrilledChook
Upgrade: Rails version 7.1 (#4735)
7778100 
This commit:
* Run bundle update
* Run `app:update` task and resolve conflicts in config & env files
* Run safe autocorrect fixes for new Rubocop offences
* Add rubocop-rspec_rails to Rubcop config
* Manually fix new unsafe Rubcop offences
  * Requires fixing some specs as some elements became ambiguous due to
    preferring more generic `click_on` Capybara helper instead of `click_link`
* Add generators to new `autoload_lib` configuration
  * Because: CI breaks otherwise
* Access schema migration object via base connection in Heroku task
  * Because: This behaviour was removed in rails 7.1.
    See https://github.com/rails/rails/blob/7-1-stable/activerecord/CHANGELOG.md
* Toggle low risk framework defaults for Rails 7.1
@ChargrilledChook ChargrilledChook mentioned this issue Aug 11, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChargrilledChook ChargrilledChook

Labels
ruby Pull requests that update Ruby code Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Projects
Main Site
Archived in project
Milestone
No milestone
1 participant
@ChargrilledChook