-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade to Rails 7.1 #4735
Closed
2 of 3 tasks
Labels
ruby
Pull requests that update Ruby code
Type: Chore
Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Comments
ChargrilledChook
added
Type: Chore
Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
ruby
Pull requests that update Ruby code
labels
Aug 10, 2024
ChargrilledChook
added a commit
that referenced
this issue
Aug 10, 2024
* Requires fixing some specs as some elements became ambiguous due to preferring more generic `click_on` Capybara helper instead of `click_link` and `click_button` * Solved by searching within `form` - alternatively, we could use test_ids. Probably a more robust approach, but preferred not having to touch views for this pass
Merged
Merged
Related PR pointing to main one that toggles the lower risk config changes #4737 |
ChargrilledChook
added a commit
that referenced
this issue
Aug 11, 2024
This commit: * Run bundle update * Run `app:update` task and resolve conflicts in config & env files * Run safe autocorrect fixes for new Rubocop offences * Add rubocop-rspec_rails to Rubcop config * Manually fix new unsafe Rubcop offences * Requires fixing some specs as some elements became ambiguous due to preferring more generic `click_on` Capybara helper instead of `click_link` * Add generators to new `autoload_lib` configuration * Because: CI breaks otherwise * Access schema migration object via base connection in Heroku task * Because: This behaviour was removed in rails 7.1. See https://github.com/rails/rails/blob/7-1-stable/activerecord/CHANGELOG.md * Toggle low risk framework defaults for Rails 7.1
ChargrilledChook
added a commit
that referenced
this issue
Aug 11, 2024
This commit: * Run bundle update * Run `app:update` task and resolve conflicts in config & env files * Run safe autocorrect fixes for new Rubocop offences * Add rubocop-rspec_rails to Rubcop config * Manually fix new unsafe Rubcop offences * Requires fixing some specs as some elements became ambiguous due to preferring more generic `click_on` Capybara helper instead of `click_link` * Add generators to new `autoload_lib` configuration * Because: CI breaks otherwise * Access schema migration object via base connection in Heroku task * Because: This behaviour was removed in rails 7.1. See https://github.com/rails/rails/blob/7-1-stable/activerecord/CHANGELOG.md * Toggle low risk framework defaults for Rails 7.1
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ruby
Pull requests that update Ruby code
Type: Chore
Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Checks
Chore: brief description of chore
format, e.g.Chore: Lesson complete button does not update on click
Chore description
Upgrade our Rails version to 7.1.x.x
Acceptance criteria
Additional Comments
This can potentially be split up into several PR's with a phased approach.
config/initializers/new_framework_defaults_7_1.rb
file (this step could be multiple PRs in itself)config/application.rb
to 7.1Tasks
The text was updated successfully, but these errors were encountered: