Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forked your library, now all files are hosted on esp8266 itself. #2

Open
wvdv2002 opened this issue Mar 20, 2016 · 4 comments
Open

Comments

@wvdv2002
Copy link

Hi TheAustrian,

Wanted to thank you for the code you wrote. I forked your code and changed it so now all files can be hosted on the ESP8266 itself. I don't know if this is useful for you too, so I did not issue a pull request. There is still some work to be done, especially for the animations to be not blocking anymore. Bit it works for now.

The code was used to control my block of wood with ledstrips in it. 2 pictures:
interface on esp
block1
block2

@TheAustrian
Copy link
Owner

Wow, an awesome project! The block looks very stylish!
Thanks for letting me know & great that the code was useful to you!

A good idea having the ESP host all files - if you want I can link to it in the readme (or however else makes sense on Github, so that people find it easily).

I'm currently working on making an Ikea "Deathstar" lamp with a motor, but the parts are only slowly arriving from China - once they do I'll have to make a new .ino-file for that and also update the website code, so that it works with multiple ESPs. But at the moment I can't test how it works...

@TheAustrian
Copy link
Owner

As for blocking animations - I made some of them compute faster by using RGB-Sets from FastLED, I updated the code accordingly.

@wvdv2002
Copy link
Author

Great, I used your changes and added some of my own to remove all delays. I tried to figure out how to do a pull request with only that single file in it. So you can use my improved version as well. I have no clue how to do that. The fact that I forked your repository and moved the file and did a lot of changes and then only wanting to sync back one commit has me dazzled. If you know how to do that, please let me know.

You are free to place a link in the Readme.md to my repository, I would be honored. Thanks!

@TheAustrian
Copy link
Owner

Thanks! I linked to it in the readme & will definitely have a closer look at it and see which improvements also make sense in this version, if I may (will take a few days due to other stuff going on). As for Github commit & pull request details - I have no idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants