-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Update "list" implementation #956
Comments
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks for your interest in contributing! 🚀 Let us know if you need any help. Thank you. |
Sure, I would like to work on that :) |
please assign this to me, i will do it in 2 days |
@ybrenning, are you still willing to work on this? Thanks. |
@Panquesito7 @ybrenning Can I work on this issue? And, I would also like to hear what other methods needs to be included apart from the ones below? append(int val) |
I can fix this,can you assign this to me? |
@ybrenning can you assign me this task? I want to support and contribute to this project now and in the future. It would be an honor to be part of this amazing open-source project. |
Detailed description
I would like to overhaul the implementation in
list.c
as it currently seems to be implementing some kind of abstract version of a stack data structure. I would propose to change this to a kind of dynamic array, similar to how thelist
data type is used in Python or theArrayList
in Java.I would also like to add some improved documentation in accordance with CONTRIUBUTING.md as well as basic testing to demonstrate the functionality of the list.
The current implementation only allows for pushing to the front of the "list" (no pop operator or possibility for deletion of elements) and has no way of displaying the contents of the list without converting it to an array first and then using a seperately implemented print function which seems unnecessarily convoluted.
Context
I think that this implementation would be a lot more fitting for the
list
data structure and would be more easy to understand as well as more flexible to use. It would allow for basic operations such as insertion, deletion and printing which aren't entirely possible yet. The improved documentation and simple tests would of course also help in making the code easier to understand.Possible implementation
Use a struct which keeps track of the current size/length of the list, the current capacity which would allow for resizing and keeps track of the current maximum amount of elements and a pointer to the beginning of the actual elements of the list.
Additional information
No response
The text was updated successfully, but these errors were encountered: