Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default colors in ASAP7 are too dark when used on black #3165

Closed
oharboe opened this issue Apr 12, 2023 · 22 comments · Fixed by #5982
Closed

Default colors in ASAP7 are too dark when used on black #3165

oharboe opened this issue Apr 12, 2023 · 22 comments · Fixed by #5982

Comments

@oharboe
Copy link
Collaborator

oharboe commented Apr 12, 2023

Description

The text against black for these pins is illegible.

image

Suggested Solution

Have a default color scheme that's better adapted to be readable against black background.

Additional Context

Of course it is possible to change the colors in the GUI, but this feature request is about readability in the default case without needing to configure things.

@antonblanchard
Copy link
Contributor

I've also noticed that the lowest layer color (dark blue / RGB(0, 0, 254)) is hard to see, eg the preferred/non preferred tracks. Perhaps the color palette used is more suited to a white background.

// Default colors

@maliberty
Copy link
Member

We could turn off the alpha for the text which would make it a bit clearer. The color of the text matches the layer color which is useful if you have pins on multiple layers.
image
vs
image
We could just draw it in white as instead.

@gadfort @rovinski any preferences?

@maliberty
Copy link
Member

I see that http://vrl.cs.brown.edu/color has changed some since I generated those colors (more knobs). I don't get the same set anymore fwiw. I'm open to suggestions. The first three layers have traditional values and I wouldn't change them too far.

@gadfort
Copy link
Collaborator

gadfort commented Apr 13, 2023

@maliberty I would prefer to preserve the color of the text to match that of the layer, so removing the alpha might be a good solution

@rovinski
Copy link
Member

Indifferent

@maliberty
Copy link
Member

@antonblanchard you might try setting the alpha=255 for m1 and see if that helps with tracks.

@gadfort
Copy link
Collaborator

gadfort commented Oct 18, 2024

@maliberty is this still a thing?

@oharboe oharboe reopened this Oct 18, 2024
@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

Yes, still hard to see.

@maliberty
Copy link
Member

I don't find it hard to see in this case
image

do you disagree?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

I don't find it hard to see in this case image

do you disagree?

I find it hard to see, yes. I'll ask a few colleagues.

@maliberty
Copy link
Member

Do you find it hard to see other shapes on that layer or just the text?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

Do you find it hard to see other shapes on that layer or just the text?

Both.

@maliberty
Copy link
Member

The text against black for these pins is illegible.

If this a general color issue and not a text issue that's somewhat different. You can change the color by double clicking the color chip.

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

The text against black for these pins is illegible.

If this a general color issue and not a text issue that's somewhat different. You can change the color by double clicking the color chip.

The feature request here is that openroad ships with color scheme(s) that don't have to be tweaked to get something readable.

@maliberty
Copy link
Member

I tried http://vrl.cs.brown.edu/color with
image
image

and get
image

How does that seem? Perhaps you can play around and see if you find a palette that works for you.

@maliberty
Copy link
Member

Readability is subjective - I find it does that already. You need to be more specific/helpful to get anything to happen.

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

Pointer to OpenROAD code where this is stored?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

Readability is subjective - I find it does that already. You need to be more specific/helpful to get anything to happen.

I'll try to make it quantitative: running a poll now.

@maliberty
Copy link
Member

// From http://vrl.cs.brown.edu/color seeded with #00F, #F00, #0D0

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

@maliberty Quick poll by 3 colleagues no-one thought it was easy, 2x hard to read, 1x readable but could be brighted.

@maliberty
Copy link
Member

I already gave a suggestion above but got no response.

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 18, 2024

I made a PR... #5982

oharboe added a commit to Pinata-Consulting/OpenROAD that referenced this issue Oct 19, 2024
oharboe added a commit to Pinata-Consulting/OpenROAD that referenced this issue Oct 19, 2024
oharboe added a commit to Pinata-Consulting/OpenROAD that referenced this issue Oct 19, 2024
oharboe added a commit to Pinata-Consulting/OpenROAD that referenced this issue Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants