-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add running times to .json files #2506
Comments
@jeffng-or FYI |
Runtimes are fine to add (though I wouldn't set any metric limit on them). Just because you have small skew/crpr on the worst path doesn't really tell you a lot. You might have terrible values on the second-worst path. What decision will you make based on these metrics? |
@maliberty Add running times for now and close this issue? As you say, skew/CRPR is more of an in depth investigation than a simple metric issue. |
Yes. Are you planning to make a PR or requesting PII do it? |
It is a feature request to the community. It is not urgent. You asked why I'm not using the .json files in megaboom and I filed a few github issues w.r.t. issues with using the .json files. |
make elapsed could be rolled into .json if generation of .json files works SKIP_REPORT_METRICS=0 |
Description
Based on my current best understanding, I would like to see the following added to the .json files:
Once running time is in the .json file, the
make elapsed
could be modified to use .json file information to reduce code duplication.Suggested Solution
Add running time to .json file
Additional Context
No response
The text was updated successfully, but these errors were encountered: