Newline between group items in table cell

[pawamoy]

Coming from #1951, I tried the following:

from rich import print
from rich.console import Group
from rich.markdown import Markdown
from rich.padding import Padding
from rich.table import Table
from rich.text import Text

table = Table(box=None, expand=False)
table.add_column(justify="left", ratio=1)
table.add_column(ratio=2)

table.add_row(
    Text("Global options", justify="left"),
    Text(),
)
table.add_row(
    Padding("[-c, --config CONFIG]", (0, 0, 0, 2)),
    Group(
        Text("Path to the configuration file."),
        Markdown(
            "Default: `~/.config/project/project.toml`.",
            style="dim italic",
        ),
        fit=True,
    ),
)

print(table)

Output:

 Global options                                                                                                                                                                                  
   [-c, --config CONFIG]  Path to the configuration file.                                                                                                                                        
                          Default: ~/.config/project/project.toml.

I was expecting:

 Global options                                                                                                                                                                                  
   [-c, --config CONFIG]  Path to the configuration file. Default: ~/.config/project/project.toml.

I tried using Columns instead of Group, but it also separates both lines.

[willmcgugan]

Markdown will use up the available width. Why combine your text with the Markdown?

If you don't want to do that, you could replace the Group with another Table.

[willmcgugan]

The Markdown doesn't have a __rich_measure__ methods which is what calculates the optimal width. It hasn't been a requirement, because you generally want the markdown to use all the widget available. You could extend Markdown and implement that. I might accept a PR if it doesn't break anything...

[pawamoy]

Actually I'm transforming Markdown to Text instances, and Text instances seem to use all width too (in a Group):

console = Console()

def markdown_to_text(renderables: Sequence[RenderableType]) -> Iterator[Text]:
    for renderable in renderables:
        if isinstance(renderable, Markdown):
            for segment in console.render(renderable):
                yield Text(segment.text, style=segment.style)
        else:
            yield renderable

...printing something like:

    [-c, --config CONFIG]                                                Path to the configuration file.                                                                  
                                                                                                                                                                                                 
                                                                                                                                                                                                 
                                                                         Default:                                                                                                                
                                                                         /home/pawamoy/.config/insiders/insiders.toml                                                                            
                                                                         .            

I tried setting end="" to the text instances, but these instances then just disappear.

[willmcgugan]

Sorry, that's not going to work. It's going to mangle the Markdown. You just can't fit the formatting done in Markdown in to Text objects.

[pawamoy]

Oh, OK 😕 Well, I managed to write something that seems to work at least:

def markdown_to_text(renderables: Sequence[RenderableType]) -> Text:
    result = Text()
    for renderable in renderables:
        if isinstance(renderable, Markdown):
            for segment in console.render(renderable):
                text = segment.text.strip("\n")
                if text.startswith(" "):  # dedup leading spaces
                    text = " " + text.lstrip()
                if text.endswith(" "):  # dedup trailing spaces
                    text = text.rstrip() + " "
                if text:
                    result.append(Text(text, style=segment.style, end=""))
        else:
            result.append(renderable)
    return result

(All "default" parts would previously appear on a new line)

[pawamoy]

By the way the first lines were Markdown in fact, explaining why the new line. So yeah, __rich_measure__ would be an interesting solution. Can't promise anything but I'll try to look at it 🙂 Thanks again!