Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree node images - add transparent background #1169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rowo360
Copy link
Contributor

@rowo360 rowo360 commented Dec 22, 2024

This PR fixes #1168 by updating the tree node images.
I separated the changes into 5 individual commits in order to improved the overview.

@rowo360
Copy link
Contributor Author

rowo360 commented Dec 22, 2024

The first commit is actually the only code change. It's taking care that the images are not displayed with any artifacts on 4k monitors by setting the ColorDepth of the ImageList to Depth32Bit. We didn't set this property previously explicitly, but instead it's default value was applied which is Depth8Bit.
This default value (Depth8Bit) is also applied after the ImageList is initialized from an ImageStream in the designer code. So overall, I decided to remove this initialization from the ImageStream completly (+ the ImageStream in the resource file).
The method LoadAlternateImages is called anyway whenever the application is started and loads the images and initialize the ImageList. This happens in case a SettingFile exists or in case of the first startup in which no SettingsFile exists.
So I adapt the method LoadAlternateImages that it's initialize the ImageList now.

@rowo360
Copy link
Contributor Author

rowo360 commented Dec 22, 2024

The 2nd commit is about adding transparent background to the images of the Style 'Default' and 'Visual studio'. I'm adding some screenshots now, because otherwise it is not possible to understand the differences.
Most important - I only added the transparency, but didn't want to adapt the images itself.

I only needed to adapt the 'Ignored' image for the 'Default' style:

In the 'Visual Studio' style the transparent background was missing in several images, so I adapted them.
(Upper line: old images; Bottom line: new images)

@rowo360
Copy link
Contributor Author

rowo360 commented Dec 22, 2024

The 3rd commit is a about adding transparent background to the images of the style 'Classic'.
Again here's the screenshot and again I didn't adapt the images itself, but only added the transparency.

In addition I needed to change the file format from jpg to png to support the transparency.

@rowo360
Copy link
Contributor Author

rowo360 commented Dec 22, 2024

The 4th commit is a about adding transparent background to the images of the style 'Circle'.
This time I adjusted the images by painting the circle with a uniform color. I have the impression that this makes the images look cleaner. Here's the screenshot:

Also this time I needed to change the file format from jpg to png to support the transparency.

@rowo360
Copy link
Contributor Author

rowo360 commented Dec 22, 2024

The last commit is dealing with the Build.cake script.
It must be adapted to deal with the new png files instead of the jpg files for the 'Classic' and 'Circle' style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tree node icons
1 participant