-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tree node icons #1168
Comments
Not surprising. Those two were originally designed on a 640x480 display! And of course, I'm not a designer either. :-) |
I laughed out loud when I read your comment about 640x480 displays! |
Here's some additional consideration: Another idea might be to introduce 32x32 images only for the toolbar - but I don't see any benefit here. |
My idea now is to use the ColorDepth property and leave the icons unchanged, except for the transparency. |
A little bit off topic: |
Most people will be running under 4.8 these days anyway, so it's possible. They will receive the benefit of any improvements unless those improvements require us to make some call that's not available under 4.6.2. If that's the case, we can upgrade our build at some point. |
Describe the bug
I propose that we update the icons used in the tree view for the test outcomes.
Here's a screenshot to show the context:
These icons are available in four different styles: 'Default', 'Circles', 'Classic' and 'Visual Studio'. All of them should be updated.
An update is necessary because most of these icons do not have a transparent background. That missing transparent background gets visible when using these icons in the outcome filter toolbar. (Introduced for feature #1163)
As a consequence the icons for the style 'Circles' and 'Classic' must be converted from jpg to png files, because transparency is only supported in png format.
And finally I noticed that some icons in the 'Circles' and 'Classic' style are not displayed correctly on a 4k monitor. I didn't notice it on other displays, so it might be related to scaling. But ultimately it doesn't look pretty.
Expected behavior
All these icons should use a transparent background and should be displayed correctly on all kind of displays (incl. 4K)
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: