Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upload] ImageCard希望增加Image属性透传 #3271

Open
Except10n opened this issue Dec 7, 2024 · 4 comments
Open

[Upload] ImageCard希望增加Image属性透传 #3271

Except10n opened this issue Dec 7, 2024 · 4 comments
Assignees
@HaixingOoO
Labels
enhancement New feature or request to be published fixed, not be published

Comments

@Except10n
Copy link
Contributor

这个功能解决了什么问题

tdesign-react/src/upload/themes/ImageCard.tsx

Line 49 in 2c09fbe

<Image className={`${classPrefix}-upload__card-image`} src={file.url || file.raw} error="" loading="" />

你建议的方案是什么

希望支持 ...props.thumbProps 之类的透传属性， 方便调整 <Image>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

👋 @Except10n，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@HaixingOoO HaixingOoO added the enhancement New feature or request label Dec 7, 2024
@Except10n
Copy link
Contributor Author

补充一个UI bug

image

@huangchen1031
Copy link
Collaborator

补充一个UI bug

image

这个问题vue和next也有，要改蛮多地方呢。。。

This was referenced Dec 17, 2024
Merged
Merged
Merged
Merged
@uyarn uyarn added the to be published fixed, not be published label Jan 6, 2025
@uyarn
Copy link
Collaborator

uyarn commented Jan 6, 2025

会增加 imageProps 这个API

HaixingOoO added a commit that referenced this issue Jan 7, 2025
@HaixingOoO
feat(upload): image-card support imageProps
0cc28ca 
#3271
@HaixingOoO HaixingOoO mentioned this issue Jan 7, 2025
Merged
16 tasks
uyarn pushed a commit that referenced this issue Jan 8, 2025
@HaixingOoO
feat(Upload): image-card support imageProps (#3317)
6f1a2f1 
* feat(upload): image-card support imageProps

#3271

* test(upload): update test snap

* chore: text starts with lowercase letters

---------

Co-authored-by: Heising <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HaixingOoO HaixingOoO

Labels
enhancement New feature or request to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Except10n @huangchen1031 @uyarn @HaixingOoO