Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prettier quit unexpectedly and lint code #1676

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

RSS1102
Copy link
Collaborator

@RSS1102 RSS1102 commented Dec 10, 2024

chore: suppress deprecation notice of tsconfig suppressImplicitAnyIndexErrors

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

befor

after
image

📝 更新日志

  • fix: 修复 prettier 意外退出的错误

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

chore: suppress deprecation notice of tsconfig `suppressImplicitAnyIndexErrors`
Copy link
Contributor

github-actions bot commented Dec 10, 2024

完成

src/search/type.ts Outdated Show resolved Hide resolved
src/search/search.tsx Outdated Show resolved Hide resolved
@anlyyao anlyyao changed the title fix: prettier quit unexpectedly and lint code 【WIP】fix: prettier quit unexpectedly and lint code Dec 10, 2024
@RSS1102 RSS1102 marked this pull request as draft December 10, 2024 13:41
@liweijie0812
Copy link
Collaborator

这个只处理 prettier 相关的问题吧 ,其他问题还是另开PR处理

@RSS1102
Copy link
Collaborator Author

RSS1102 commented Dec 11, 2024

这个只处理 prettier 相关的问题吧 ,其他问题还是另开PR处理

ok

@RSS1102 RSS1102 changed the title 【WIP】fix: prettier quit unexpectedly and lint code fix: prettier quit unexpectedly and lint code Dec 11, 2024
@RSS1102 RSS1102 marked this pull request as ready for review December 11, 2024 03:00
@RSS1102
Copy link
Collaborator Author

RSS1102 commented Dec 11, 2024

已将代码进行回退

@anlyyao
Copy link
Collaborator

anlyyao commented Dec 11, 2024

这个只处理 prettier 相关的问题吧 ,其他问题还是另开PR处理

@liweijie0812 辛苦继续 review code

@liweijie0812
Copy link
Collaborator

./helper目录 修改还原,文件是通过 API 平台生成的

@RSS1102
Copy link
Collaborator Author

RSS1102 commented Dec 11, 2024

./helper目录 修改还原,文件是通过 API 平台生成的

那 lint 时是否应将其过滤

@liweijie0812
Copy link
Collaborator

可忽略,减少不必要的变更出来

@anlyyao anlyyao merged commit 8375507 into Tencent:develop Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants