You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we return a ConfigQemu.CloudInit object when no cloud-init disk has been configured?
When no cloud-init disk is configured the settings don't do anything. The PVE gui still shows the information all be it grayed out.
I do feel like checking if ConfigQemu.CloudInit == nil is the most intuitive way of checking if the vm uses cloud-init settings.
The alternative would be to check if a cloud-init disk is configured and check if ConfigQemu.CloudInit == nil.
Making users check if a cloud-init disk is configured feels like a lot to ask, especially with how the disks are implemented.
so we should make ConfigQemu.CloudInit = nil when no cloud-init disk is configured.
Should we return a
ConfigQemu.CloudInit
object when no cloud-init disk has been configured?When no cloud-init disk is configured the settings don't do anything. The PVE gui still shows the information all be it grayed out.
I do feel like checking if
ConfigQemu.CloudInit == nil
is the most intuitive way of checking if the vm uses cloud-init settings.The alternative would be to check if a cloud-init disk is configured and check if
ConfigQemu.CloudInit == nil
.Making users check if a cloud-init disk is configured feels like a lot to ask, especially with how the disks are implemented.
so we should make
ConfigQemu.CloudInit = nil
when no cloud-init disk is configured.@mleone87 whats your opinion on this?
proxmox-api-go/proxmox/config_qemu.go
Lines 32 to 39 in 602cfe7
The text was updated successfully, but these errors were encountered: