Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite of the NPC and version-specific code #118

Open
Techcable opened this issue Sep 19, 2018 · 0 comments
Open

Complete rewrite of the NPC and version-specific code #118

Techcable opened this issue Sep 19, 2018 · 0 comments
Assignees
Milestone

Comments

@Techcable
Copy link
Member

I feel like the NPC code is the most fragile part of the codebase.
It's been getting better, but I think I need to move all of the pet-related logic out of the NPC logic for cleanliness.
Interaction with the new NPC code will simply involve listening for events and .
The new interface must cleanly support multiple NPCs and human NPCs.
It must be lightweight, of high quality, and well-encapsulated so that someday I can pull it out and maintain it as a separate library.
Instead of using bytecode generation or magic template libraries, I intend to use readable python code to generate the version-specific code.

This will be the first of many improvements on the way to v2.0.0 and will pave the way for multiple pets, human pets, and much quicker updates to new Minecraft versions.

@Techcable Techcable added this to the 1.1.0 milestone Sep 19, 2018
@Techcable Techcable self-assigned this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant